From 00b6b0ac68571df1a7c8e16fd0e79c64cbfe0a60 Mon Sep 17 00:00:00 2001 From: Benjamin Yolken Date: Fri, 3 Feb 2017 15:43:43 -0800 Subject: [PATCH] Misc. style tweaks to S3Cache changes and tests --- superset/results_backends.py | 1 + tests/results_backends_tests.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/superset/results_backends.py b/superset/results_backends.py index 614d28c2f..ccf755fc7 100644 --- a/superset/results_backends.py +++ b/superset/results_backends.py @@ -35,6 +35,7 @@ class S3Cache(BaseCache): self.default_timeout = default_timeout self.s3_client = boto3.client('s3') + self.bucket = config.get('S3_CACHE_BUCKET') self.key_prefix = config.get('S3_CACHE_KEY_PREFIX') diff --git a/tests/results_backends_tests.py b/tests/results_backends_tests.py index 8ebbb53a7..f628ebdbf 100644 --- a/tests/results_backends_tests.py +++ b/tests/results_backends_tests.py @@ -1,4 +1,5 @@ import cPickle + import mock from superset import app, results_backends @@ -44,7 +45,7 @@ class ResultsBackendsTests(SupersetTestCase): self.assertEquals(call_args[1], 'test-bucket') self.assertEquals(call_args[2], 'test-prefix/test-key') - def test_s3_cache_exception(self): + def test_s3_cache_set_exception(self): self.mock_s3_client.upload_fileobj.side_effect = Exception('Something bad happened!') result = self.s3_cache.set('test-key', 'test-value')