iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(viz): rename v1 and v2 charts (#22369)

This commit is contained in:
Ville Brofeldt 2022-12-09 22:51:37 +02:00 committed by GitHub
parent 3b45ad8b97
commit 012d1300c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
13 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
superset-frontend/cypress-base/cypress/integration/chart_list/filter.test.ts
View File

@ -50,7 +50,7 @@ describe('Charts filters', () => {
});
it('should filter by viz type correctly', () => {
setFilter('Chart type', 'Area Chart');
setFilter('Chart type', 'Area Chart (legacy)');
cy.getBySel('styled-card').should('have.length', 3);
setFilter('Chart type', 'Bubble Chart');
cy.getBySel('styled-card').should('have.length', 2);
@ -91,7 +91,7 @@ describe('Charts filters', () => {
});
it('should filter by viz type correctly', () => {
setFilter('Chart type', 'Area Chart');
setFilter('Chart type', 'Area Chart (legacy)');
cy.getBySel('table-row').should('have.length', 3);
setFilter('Chart type', 'Bubble Chart');
cy.getBySel('table-row').should('have.length', 2);

4
superset-frontend/cypress-base/cypress/integration/dashboard/drilltodetail.test.ts
View File

@ -339,7 +339,7 @@ describe('Drill to detail modal', () => {
});
});
describe('Time-series Bar Chart V2', () => {
describe('Time-series Bar Chart', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();
@ -591,7 +591,7 @@ describe('Drill to detail modal', () => {
});
});
describe('Treemap V2', () => {
describe('Treemap', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();

2
superset-frontend/plugins/legacy-plugin-chart-pivot-table/src/index.js
View File

@ -27,7 +27,7 @@ const metadata = new ChartMetadata({
t(`Used to summarize a set of data by grouping together multiple statistics along two axes. Examples: Sales numbers by region and month, tasks by status and assignee, active users by age and location.
This chart is being deprecated and we recommend checking out Pivot Table V2 instead!`),
name: t('Pivot Table'),
name: t('Pivot Table (legacy)'),
tags: [t('Legacy')],
thumbnail,
useLegacyApi: true,

2
superset-frontend/plugins/legacy-plugin-chart-treemap/src/index.js
View File

@ -37,7 +37,7 @@ const metadata = new ChartMetadata({
{ url: example3 },
{ url: example4 },
],
name: t('Treemap'),
name: t('Treemap (legacy)'),
tags: [
t('Categorical'),
t('Legacy'),

2
superset-frontend/plugins/legacy-preset-chart-nvd3/src/Area/index.js
View File

@ -38,7 +38,7 @@ const metadata = new ChartMetadata({
{ url: example3, caption: t('Video game consoles') },
{ url: example4, caption: t('Vehicle Types') },
],
name: t('Area Chart'),
name: t('Area Chart (legacy)'),
supportedAnnotationTypes: [ANNOTATION_TYPES.INTERVAL, ANNOTATION_TYPES.EVENT],
tags: [
t('Aesthetic'),

2
superset-frontend/plugins/legacy-preset-chart-nvd3/src/Bar/index.js
View File

@ -32,7 +32,7 @@ const metadata = new ChartMetadata({
'Visualize how a metric changes over time using bars. Add a group by column to visualize group level metrics and how they change over time.',
),
exampleGallery: [{ url: example1 }, { url: example2 }, { url: example3 }],
name: t('Time-series Bar Chart'),
name: t('Time-series Bar Chart (legacy)'),
supportedAnnotationTypes: [ANNOTATION_TYPES.INTERVAL, ANNOTATION_TYPES.EVENT],
tags: [
t('Bar'),

2
superset-frontend/plugins/legacy-preset-chart-nvd3/src/Line/index.js
View File

@ -35,7 +35,7 @@ const metadata = new ChartMetadata({
{ url: example2 },
{ url: battery, caption: t('Battery level over time') },
],
name: t('Line Chart'),
name: t('Line Chart (legacy)'),
supportedAnnotationTypes: [
ANNOTATION_TYPES.TIME_SERIES,
ANNOTATION_TYPES.INTERVAL,

2
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Area/index.ts
View File

@ -68,7 +68,7 @@ export default class EchartsAreaChartPlugin extends ChartPlugin<
AnnotationType.Timeseries,
],
name: hasGenericChartAxes
? t('Area Chart v2')
? t('Area Chart')
: t('Time-series Area Chart'),
tags: [
t('ECharts'),

4
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/index.ts
View File

@ -75,9 +75,7 @@ export default class EchartsTimeseriesBarChartPlugin extends ChartPlugin<
AnnotationType.Interval,
AnnotationType.Timeseries,
],
name: hasGenericChartAxes
? t('Bar Chart v2')
: t('Time-series Bar Chart v2'),
name: hasGenericChartAxes ? t('Bar Chart') : t('Time-series Bar Chart'),
tags: [
t('ECharts'),
t('Predictive'),

2
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Line/index.ts
View File

@ -73,7 +73,7 @@ export default class EchartsTimeseriesLineChartPlugin extends ChartPlugin<
AnnotationType.Timeseries,
],
name: hasGenericChartAxes
? t('Line Chart v2')
? t('Line Chart')
: t('Time-series Line Chart'),
tags: [
t('ECharts'),

2
superset-frontend/plugins/plugin-chart-echarts/src/Treemap/index.ts
View File

@ -53,7 +53,7 @@ export default class EchartsTreemapChartPlugin extends ChartPlugin<
'Show hierarchical relationships of data, with with the value represented by area, showing proportion and contribution to the whole.',
),
exampleGallery: [{ url: example1 }, { url: example2 }],
name: t('Treemap v2'),
name: t('Treemap'),
tags: [
t('Aesthetic'),
t('Categorical'),

2
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/index.ts
View File

@ -51,7 +51,7 @@ export default class PivotTableChartPlugin extends ChartPlugin<
description: t(
'Used to summarize a set of data by grouping together multiple statistics along two axes. Examples: Sales numbers by region and month, tasks by status and assignee, active users by age and location. Not the most visually stunning visualization, but highly informative and versatile.',
),
name: t('Pivot Table v2'),
name: t('Pivot Table'),
tags: [t('Additive'), t('Report'), t('Tabular'), t('Popular')],
thumbnail,
});

8
superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeControl.test.tsx
View File

@ -139,7 +139,7 @@ describe('VizTypeControl', () => {
).toBeInTheDocument();
expect(
within(screen.getByTestId('fast-viz-switcher')).getByText(
'Time-series Bar Chart v2',
'Time-series Bar Chart',
),
).toBeInTheDocument();
expect(
@ -251,7 +251,7 @@ describe('VizTypeControl', () => {
within(visualizations).getByText('Time-series Line Chart'),
).toBeVisible();
expect(
within(visualizations).getByText('Time-series Bar Chart v2'),
within(visualizations).getByText('Time-series Bar Chart'),
).toBeVisible();
expect(
within(visualizations).queryByText('Line Chart'),
@ -269,9 +269,7 @@ describe('VizTypeControl', () => {
renderWrapper();
userEvent.click(screen.getByRole('button', { name: 'ballot All charts' }));
const visualizations = screen.getByTestId(getTestId('viz-row'));
userEvent.click(
within(visualizations).getByText('Time-series Bar Chart v2'),
);
userEvent.click(within(visualizations).getByText('Time-series Bar Chart'));
expect(defaultProps.onChange).not.toBeCalled();
userEvent.dblClick(