diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js index 591539b62..cdd7c9c88 100644 --- a/superset-frontend/.eslintrc.js +++ b/superset-frontend/.eslintrc.js @@ -60,7 +60,6 @@ module.exports = { '@typescript-eslint/no-empty-function': 0, '@typescript-eslint/no-explicit-any': 0, '@typescript-eslint/no-use-before-define': 1, // disabled temporarily - '@typescript-eslint/no-unused-vars': 0, // disabled temporarily '@typescript-eslint/explicit-function-return-type': 0, '@typescript-eslint/explicit-module-boundary-types': 0, // re-enable up for discussion camelcase: 0, diff --git a/superset-frontend/src/components/Menu/MenuObject.tsx b/superset-frontend/src/components/Menu/MenuObject.tsx index 7f13174b7..bf66a401a 100644 --- a/superset-frontend/src/components/Menu/MenuObject.tsx +++ b/superset-frontend/src/components/Menu/MenuObject.tsx @@ -39,7 +39,6 @@ export interface MenuObjectProps { export default function MenuObject({ label, - icon, childs, url, index, diff --git a/superset-frontend/src/explore/components/PropertiesModal.tsx b/superset-frontend/src/explore/components/PropertiesModal.tsx index 2b24b2345..21fd3b0f4 100644 --- a/superset-frontend/src/explore/components/PropertiesModal.tsx +++ b/superset-frontend/src/explore/components/PropertiesModal.tsx @@ -60,21 +60,6 @@ export type WrapperProps = InternalProps & { animation?: boolean; // for the modal }; -export default function PropertiesModalWrapper({ - show, - onHide, - animation, - slice, - onSave, -}: WrapperProps) { - // The wrapper is a separate component so that hooks only run when the modal opens - return ( - - - - ); -} - function PropertiesModal({ slice, onHide, onSave }: InternalProps) { const [submitting, setSubmitting] = useState(false); const errorDialog = useRef(null); @@ -279,3 +264,18 @@ function PropertiesModal({ slice, onHide, onSave }: InternalProps) { ); } + +export default function PropertiesModalWrapper({ + show, + onHide, + animation, + slice, + onSave, +}: WrapperProps) { + // The wrapper is a separate component so that hooks only run when the modal opens + return ( + + + + ); +}