iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(event-flow-viz): handle null metadata selection (#11885) 

* Initialize object with empty array if is multiselect, fix 500 BE error

* modify data coming
This commit is contained in:
Victor Malai 2020-12-08 08:53:26 +02:00 committed by GitHub
parent 8f1ac7ead1
commit 05258ebc6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/src/explore/components/controls/SelectControl.jsx
View File

@ -102,10 +102,9 @@ export default class SelectControl extends React.PureComponent {
// Beware: This is acting like an on-click instead of an on-change
// (firing every time user chooses vs firing only if a new option is chosen).
onChange(opt) {
let optionValue = null;
let optionValue = this.props.multi ? [] : null;
if (opt) {
if (this.props.multi) {
optionValue = [];
opt.forEach(o => {
// select all options
if (o.meta === true) {

2
superset/viz.py
View File

@ -2701,7 +2701,7 @@ class EventFlowViz(BaseViz):
entity_key = form_data["entity"]
meta_keys = [
col
for col in form_data["all_columns"]
for col in form_data["all_columns"] or []
if col != event_key and col != entity_key
]