From 06e0f04214bd7866328c6714687eaeffafc44f70 Mon Sep 17 00:00:00 2001
From: Craig Rueda <craig@craigrueda.com>
Date: Tue, 24 Mar 2020 10:24:23 -0700
Subject: [PATCH] Adding requirements-local.txt support (#9357)

* Adding requirements-local.txt support

* Reverting package-lock.json
---
 .gitignore       |  2 ++
 Dockerfile       |  5 +++--
 docker/README.md | 12 ++++++++++++
 3 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index d069eef06..0ccddfa4f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -80,3 +80,5 @@ apache-superset-*.tar.gz*
 
 # Translation binaries
 messages.mo
+
+docker/requirements-local.txt
diff --git a/Dockerfile b/Dockerfile
index 9f14b07aa..a10fcfe26 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -114,9 +114,10 @@ ENTRYPOINT ["/usr/bin/docker-entrypoint.sh"]
 ######################################################################
 FROM lean AS dev
 
-COPY ./requirements-dev.txt ./docker/requirements-extra.txt /app/
+COPY ./requirements-dev.txt ./docker/requirements* /app/
 
 USER root
 RUN cd /app \
-    && pip install --no-cache -r requirements-dev.txt -r requirements-extra.txt
+    && pip install --no-cache -r requirements-dev.txt -r requirements-extra.txt \
+    && pip install --no-cache -r requirements-local.txt || true
 USER superset
diff --git a/docker/README.md b/docker/README.md
index 62a97aa24..caed1a7b0 100644
--- a/docker/README.md
+++ b/docker/README.md
@@ -37,6 +37,18 @@ intended for use with local development.
 In order to override configuration settings locally, simply make a copy of [./docker/pythonpath/superset_config_local.example](./docker/pythonpath/superset_config_local.example)
 into [./docker/pythonpath/superset_config_docker.py](./docker/pythonpath/superset_config_docker.py) (git ignored) and fill in your overrides.
 
+### Local packages
+
+If you want to add python packages in order to test things like DBs locally, you can simply add a local requirements.txt (./docker/requirements-local.txt)
+and rebuild your docker stack.
+
+Steps:
+    1. Create ./docker/requirements-local.txt
+    2. Add your new packages
+    3. Rebuild docker-compose
+        a. `docker-compose down -v`
+        b. `docker-compose up`
+
 ## Initializing Database
 
 The DB will initialize itself upon startup via the init container (superset-init)