iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style(explore): clarify ambiguously named "sort by" field (#30254)

This commit is contained in:
Sam Firke 2024-09-18 15:18:42 -04:00 committed by GitHub
parent a3952051e1
commit 08145d88b9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
View File

@ -188,11 +188,12 @@ export const dndSortByControl: SharedControlConfig<
'DndMetricSelect' | 'MetricsControl' 'DndMetricSelect' | 'MetricsControl'
> = { > = {
type: 'DndMetricSelect', type: 'DndMetricSelect',
label: t('Sort by'), label: t('Sort query by'),
default: null, default: null,
description: t( description: t(
'This metric is used to define row selection criteria (how the rows are sorted) if a series or row limit is present. ' + 'Orders the query result that generates the source data for this chart. ' +
'If not defined, it reverts to the first metric (where appropriate).', 'If a series or row limit is reached, this determines what data are truncated. ' +
'If undefined, defaults to the first metric (where appropriate).',
), ),
mapStateToProps: ({ datasource }) => ({ mapStateToProps: ({ datasource }) => ({
columns: datasource?.columns || [], columns: datasource?.columns || [],