iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: clean up incorrect usage of TypeScript type in PropTypes (#13681)

This commit is contained in:
Jesse Yang 2021-03-18 09:12:13 -07:00 committed by GitHub
parent 577ecc284f
commit 08d0deb720
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.jsx
View File

@ -18,20 +18,13 @@
*/
import React from 'react';
import PropTypes from 'prop-types';
import { Metric } from '@superset-ui/chart-controls/lib/types';
import columnType from './columnType';
import AdhocMetricOption from './AdhocMetricOption';
import AdhocMetric from './AdhocMetric';
import savedMetricType from './savedMetricType';
import adhocMetricType from './adhocMetricType';
const propTypes = {
option: PropTypes.oneOfType([
savedMetricType,
adhocMetricType,
Metric,
PropTypes.string,
]).isRequired,
option: PropTypes.oneOfType([PropTypes.object, PropTypes.string]).isRequired,
index: PropTypes.number.isRequired,
onMetricEdit: PropTypes.func,
onRemoveMetric: PropTypes.func,

6
superset-frontend/src/explore/components/controls/withAsyncVerification.tsx
View File

@ -23,8 +23,10 @@ import React, {
useRef,
useState,
} from 'react';
import sharedControlComponents from '@superset-ui/chart-controls/lib/shared-controls/components';
import { ExtraControlProps } from '@superset-ui/chart-controls';
import {
ExtraControlProps,
sharedControlComponents,
} from '@superset-ui/chart-controls';
import { JsonArray, JsonValue, t } from '@superset-ui/core';
import { ControlProps } from 'src/explore/components/Control';
import builtInControlComponents from 'src/explore/components/controls';