iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: Transform URLShortLinkModal to Typescript (#11971) 

* Transform jsx modal to tsx modal

* Change required type

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
This commit is contained in:
Victor Malai 2020-12-15 18:12:00 +02:00 committed by GitHub
parent f79e52f48e
commit 12e086dc61
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
superset-frontend/src/components/URLShortLinkModal.jsx → superset-frontend/src/components/URLShortLinkModal.tsx
View File

@ -17,24 +17,38 @@
* under the License.
*/
import React from 'react';
import PropTypes from 'prop-types';
import { t } from '@superset-ui/core';
import CopyToClipboard from './CopyToClipboard';
import { getShortUrl } from '../utils/common';
import withToasts from '../messageToasts/enhancers/withToasts';
import ModalTrigger from './ModalTrigger';
const propTypes = {
url: PropTypes.string,
emailSubject: PropTypes.string,
emailContent: PropTypes.string,
addDangerToast: PropTypes.func.isRequired,
title: PropTypes.string,
triggerNode: PropTypes.node.isRequired,
type URLShortLinkModalProps = {
url: string;
emailSubject: string;
emailContent: string;
title?: string;
addDangerToast: (msg: string) => void;
triggerNode: JSX.Element;
};
class URLShortLinkModal extends React.Component {
constructor(props) {
type URLShortLinkModalState = {
shortUrl: string;
};
class URLShortLinkModal extends React.Component<
URLShortLinkModalProps,
URLShortLinkModalState
> {
static defaultProps = {
url: window.location.href.substring(window.location.origin.length),
emailSubject: '',
emailContent: '',
};
modal: ModalTrigger | null;
constructor(props: URLShortLinkModalProps) {
super(props);
this.state = {
shortUrl: '',
@ -45,11 +59,11 @@ class URLShortLinkModal extends React.Component {
this.getCopyUrl = this.getCopyUrl.bind(this);
}
onShortUrlSuccess(shortUrl) {
onShortUrlSuccess(shortUrl: string) {
this.setState(() => ({ shortUrl }));
}
setModalRef(ref) {
setModalRef(ref: ModalTrigger | null) {
this.modal = ref;
}
@ -88,12 +102,4 @@ class URLShortLinkModal extends React.Component {
}
}
URLShortLinkModal.defaultProps = {
url: window.location.href.substring(window.location.origin.length),
emailSubject: '',
emailContent: '',
};
URLShortLinkModal.propTypes = propTypes;
export default withToasts(URLShortLinkModal);