From 157482955e3e87c6bfa57757a82c8c49e25da512 Mon Sep 17 00:00:00 2001 From: "JUST.in DO IT" Date: Sun, 2 Oct 2022 19:51:55 -0700 Subject: [PATCH] chore: avoid undefined property on `Global` type (#21631) --- .../packages/superset-ui-switchboard/src/switchboard.test.ts | 4 +++- .../components/DashboardBuilder/DashboardBuilder.tsx | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/superset-frontend/packages/superset-ui-switchboard/src/switchboard.test.ts b/superset-frontend/packages/superset-ui-switchboard/src/switchboard.test.ts index fb77ab90f..fc9ed46b2 100644 --- a/superset-frontend/packages/superset-ui-switchboard/src/switchboard.test.ts +++ b/superset-frontend/packages/superset-ui-switchboard/src/switchboard.test.ts @@ -105,7 +105,9 @@ describe('comms', () => { let originalConsoleError: any = null; beforeAll(() => { - global.MessageChannel = FakeMessageChannel; // yolo + Object.defineProperty(global, 'MessageChannel', { + value: FakeMessageChannel, + }); originalConsoleDebug = console.debug; originalConsoleError = console.error; }); diff --git a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx index 85e42d903..c99d1d866 100644 --- a/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx +++ b/superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx @@ -283,7 +283,7 @@ const DashboardBuilder: FC = () => { setBarTopOffset(headerRef.current?.getBoundingClientRect()?.height || 0); let observer: ResizeObserver; - if (typeof global.ResizeObserver !== 'undefined' && headerRef.current) { + if (global.hasOwnProperty('ResizeObserver') && headerRef.current) { observer = new ResizeObserver(entries => { setBarTopOffset( current => entries?.[0]?.contentRect?.height || current,