iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: remove deprecated chart.edit_url field from frontend usage (#13142)

This commit is contained in:
David Aaron Suddjian 2021-02-16 19:54:43 -08:00 committed by GitHub
parent da478531b2
commit 189aced320
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
superset-frontend/spec/fixtures/mockSliceEntities.js vendored
View File

@ -45,7 +45,6 @@ export const sliceEntitiesForChart = {
compare_suffix: 'o10Y',
datasource: datasourceId,
},
edit_url: `/chart/edit/${sliceId}`,
viz_type: 'pie',
datasource: datasourceId,
description: null,
@ -78,7 +77,6 @@ export const sliceEntitiesForDashboard = {
},
],
},
edit_url: '/chart/edit/127',
viz_type: 'filter_box',
datasource: '2__table',
description: null,
@ -91,7 +89,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20128%7D',
slice_name: "World's Population",
form_data: {},
edit_url: '/chart/edit/128',
viz_type: 'big_number',
datasource: '2__table',
description: null,
@ -104,7 +101,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20129%7D',
slice_name: 'Most Populated Countries',
form_data: {},
edit_url: '/chart/edit/129',
viz_type: 'table',
datasource: '2__table',
description: null,
@ -117,7 +113,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20130%7D',
slice_name: 'Growth Rate',
form_data: {},
edit_url: '/chart/edit/130',
viz_type: 'line',
datasource: '2__table',
description: null,
@ -130,7 +125,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20131%7D',
slice_name: '% Rural',
form_data: {},
edit_url: '/chart/edit/131',
viz_type: 'world_map',
datasource: '2__table',
description: null,
@ -143,7 +137,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20132%7D',
slice_name: 'Life Expectancy VS Rural %',
form_data: {},
edit_url: '/chart/edit/132',
viz_type: 'bubble',
datasource: '2__table',
description: null,
@ -156,7 +149,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20133%7D',
slice_name: 'Rural Breakdown',
form_data: {},
edit_url: '/chart/edit/133',
viz_type: 'sunburst',
datasource: '2__table',
description: null,
@ -169,7 +161,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20134%7D',
slice_name: "World's Pop Growth",
form_data: {},
edit_url: '/chart/edit/134',
viz_type: 'area',
datasource: '2__table',
description: null,
@ -182,7 +173,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20135%7D',
slice_name: 'Box plot',
form_data: {},
edit_url: '/chart/edit/135',
viz_type: 'box_plot',
datasource: '2__table',
description: null,
@ -195,7 +185,6 @@ export const sliceEntitiesForDashboard = {
slice_url: '/superset/explore/?form_data=%7B%22slice_id%22%3A%20136%7D',
slice_name: 'Treemap',
form_data: {},
edit_url: '/chart/edit/136',
viz_type: 'treemap',
datasource: '2__table',
description: null,

2
superset-frontend/src/dashboard/actions/sliceEntities.js
View File

@ -57,7 +57,6 @@ export function fetchAllSlices(userId) {
'datasource_name_text',
'description_markeddown',
'description',
'edit_url',
'id',
'params',
'slice_name',
@ -87,7 +86,6 @@ export function fetchAllSlices(userId) {
slice_id: slice.id,
slice_url: slice.url,
slice_name: slice.slice_name,
edit_url: slice.edit_url,
form_data,
datasource_name: slice.datasource_name_text,
datasource_url: slice.datasource_url,

1
superset-frontend/src/dashboard/reducers/getInitialState.js
View File

@ -127,7 +127,6 @@ export default function getInitialState(bootstrapData) {
slice_url: slice.slice_url,
slice_name: slice.slice_name,
form_data: slice.form_data,
edit_url: slice.edit_url,
viz_type: slice.form_data.viz_type,
datasource: slice.form_data.datasource,
description: slice.description,

1
superset-frontend/src/dashboard/util/propShapes.jsx
View File

@ -59,7 +59,6 @@ export const slicePropShape = PropTypes.shape({
slice_id: PropTypes.number.isRequired,
slice_url: PropTypes.string.isRequired,
slice_name: PropTypes.string.isRequired,
edit_url: PropTypes.string.isRequired,
datasource: PropTypes.string,
datasource_name: PropTypes.string,
datasource_link: PropTypes.string,