diff --git a/.gitignore b/.gitignore index b1d505a2b..d069eef06 100644 --- a/.gitignore +++ b/.gitignore @@ -58,9 +58,6 @@ rat-results.txt *.js.map node_modules npm-debug.log* -superset-frontend/coverage/* -superset-frontend/cypress/screenshots -superset-frontend/cypress/videos superset/static/assets superset/static/version_info.json yarn-error.log diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1d8571acd..cef83d11c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -528,7 +528,7 @@ best practices. Superset supports a server-wide feature flag system, which eases the incremental development of features. To add a new feature flag, simply modify `superset_config.py` with something like the following: -``` +```python FEATURE_FLAGS = { 'SCOPED_FILTER': True, } @@ -536,7 +536,7 @@ FEATURE_FLAGS = { If you want to use the same flag in the client code, also add it to the FeatureFlag TypeScript enum in `superset-frontend/src/featureFlags.ts`. For example, -``` +```typescript export enum FeatureFlag { SCOPED_FILTER = 'SCOPED_FILTER', } diff --git a/superset-frontend/.eslintignore b/superset-frontend/.eslintignore index 25b08e052..e21e918be 100644 --- a/superset-frontend/.eslintignore +++ b/superset-frontend/.eslintignore @@ -25,5 +25,6 @@ stylesheets/* vendor/* docs/* src/dashboard/deprecated/* +src/temp/* **/node_modules *.d.ts diff --git a/superset-frontend/.gitignore b/superset-frontend/.gitignore new file mode 100644 index 000000000..0598bbb0b --- /dev/null +++ b/superset-frontend/.gitignore @@ -0,0 +1,4 @@ +coverage/* +cypress/screenshots +cypress/videos +src/temp diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json index 5421f93fb..291151c82 100644 --- a/superset-frontend/package-lock.json +++ b/superset-frontend/package-lock.json @@ -24728,9 +24728,9 @@ "integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=" }, "typescript": { - "version": "3.5.3", - "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.5.3.tgz", - "integrity": "sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==", + "version": "3.8.2", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.8.2.tgz", + "integrity": "sha512-EgOVgL/4xfVrCMbhYKUQTdF37SQn4Iw73H5BgCrF1Abdun7Kwy/QZsE/ssAy0y4LxBbvua3PIbFsbRczWWnDdQ==", "dev": true }, "typpy": { diff --git a/superset-frontend/package.json b/superset-frontend/package.json index f51844979..01c8cd337 100644 --- a/superset-frontend/package.json +++ b/superset-frontend/package.json @@ -220,7 +220,7 @@ "ts-jest": "^24.0.2", "ts-loader": "^5.4.5", "tslib": "^1.10.0", - "typescript": "^3.5.3", + "typescript": "^3.8.2", "url-loader": "^1.0.1", "webpack": "^4.19.0", "webpack-assets-manifest": "^3.0.1", diff --git a/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts b/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts index acf7748f1..21ea64765 100644 --- a/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts +++ b/superset-frontend/spec/javascripts/utils/safeStringify_spec.ts @@ -19,7 +19,7 @@ import { safeStringify } from '../../../src/utils/safeStringify'; class Noise { - public next: Noise; + public next?: Noise; } describe('Stringify utility testing', () => { diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js index b45a958a5..c7a957a9f 100644 --- a/superset-frontend/webpack.config.js +++ b/superset-frontend/webpack.config.js @@ -281,7 +281,7 @@ const config = { hot: true, index: '', // This line is needed to enable root proxying inline: true, - stats: { colors: true }, + stats: 'minimal', overlay: true, port: devserverPort, // Only serves bundled files from webpack-dev-server