iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: Adds a separator to Select All option (#22776)

This commit is contained in:
Michael S. Molina 2023-01-19 12:22:57 -05:00 committed by GitHub
parent af73c59b0a
commit 1fe4a71f5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/.storybook/preview.jsx
View File

@ -87,5 +87,5 @@ addParameters({
], ],
}, },
}, },
controls: { expanded: true }, controls: { expanded: true, sort: 'alpha' },
}); });

1
superset-frontend/src/components/Select/Select.tsx
View File

@ -467,6 +467,7 @@ const Select = forwardRef(
{selectAllEnabled && ( {selectAllEnabled && (
<Option <Option
id="select-all" id="select-all"
className="select-all"
key={SELECT_ALL_VALUE} key={SELECT_ALL_VALUE}
value={SELECT_ALL_VALUE} value={SELECT_ALL_VALUE}
> >

4
superset-frontend/src/components/Select/styles.tsx
View File

@ -52,7 +52,9 @@ export const StyledSelect = styled(AntdSelect, {
.ant-select-arrow .anticon:not(.ant-select-suffix) { .ant-select-arrow .anticon:not(.ant-select-suffix) {
pointer-events: none; pointer-events: none;
} }
.select-all {
border-bottom: 1px solid ${theme.colors.grayscale.light3};
}
${ ${
oneLine && oneLine &&
` `