From 1fffa37e85031d981c1609cbdc2af1733f74cd8a Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Tue, 26 May 2020 12:37:33 -0700 Subject: [PATCH] feat: remove para controls (#9851) * remove para controls * update package version --- superset-frontend/package-lock.json | 6 +- superset-frontend/package.json | 2 +- .../src/explore/controlPanels/Para.js | 64 ------------------- superset-frontend/src/setup/setupPlugins.ts | 2 - 4 files changed, 4 insertions(+), 70 deletions(-) delete mode 100644 superset-frontend/src/explore/controlPanels/Para.js diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json index 75aef04bb..7b74b656e 100644 --- a/superset-frontend/package-lock.json +++ b/superset-frontend/package-lock.json @@ -6840,9 +6840,9 @@ } }, "@superset-ui/legacy-plugin-chart-parallel-coordinates": { - "version": "0.13.3", - "resolved": "https://registry.npmjs.org/@superset-ui/legacy-plugin-chart-parallel-coordinates/-/legacy-plugin-chart-parallel-coordinates-0.13.3.tgz", - "integrity": "sha512-qFyE5vEl5D5G5KpcCG+aE7sbxZnmljR1PBiaRJ2oIcuyk28qHnxLGW8NcPeOMZwwgOJ8KxWTBNu3pyxHf0065w==", + "version": "0.13.20", + "resolved": "https://registry.npmjs.org/@superset-ui/legacy-plugin-chart-parallel-coordinates/-/legacy-plugin-chart-parallel-coordinates-0.13.20.tgz", + "integrity": "sha512-qdkRVfav6zv2J59OjTuZZooXqJDD1yybiwFTbzGgLDAqeu63gtKSaIeJVmiLRHpu5Qg6n0Vd3eb6T4Z+XDVYcw==", "requires": { "d3": "^3.5.17", "prop-types": "^15.6.2" diff --git a/superset-frontend/package.json b/superset-frontend/package.json index 8f4af8487..74f422b61 100644 --- a/superset-frontend/package.json +++ b/superset-frontend/package.json @@ -78,7 +78,7 @@ "@superset-ui/legacy-plugin-chart-map-box": "^0.13.16", "@superset-ui/legacy-plugin-chart-markup": "^0.13.12", "@superset-ui/legacy-plugin-chart-paired-t-test": "^0.13.5", - "@superset-ui/legacy-plugin-chart-parallel-coordinates": "^0.13.3", + "@superset-ui/legacy-plugin-chart-parallel-coordinates": "^0.13.20", "@superset-ui/legacy-plugin-chart-partition": "^0.13.11", "@superset-ui/legacy-plugin-chart-pivot-table": "^0.13.10", "@superset-ui/legacy-plugin-chart-rose": "^0.13.10", diff --git a/superset-frontend/src/explore/controlPanels/Para.js b/superset-frontend/src/explore/controlPanels/Para.js deleted file mode 100644 index 31526f804..000000000 --- a/superset-frontend/src/explore/controlPanels/Para.js +++ /dev/null @@ -1,64 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -import { t } from '@superset-ui/translation'; - -export default { - controlPanelSections: [ - { - label: t('Query'), - expanded: true, - controlSetRows: [ - ['series'], - ['metrics'], - ['secondary_metric'], - ['adhoc_filters'], - ['limit', 'row_limit'], - ], - }, - { - label: t('Options'), - expanded: true, - controlSetRows: [ - [ - { - name: 'show_datatable', - config: { - type: 'CheckboxControl', - label: t('Data Table'), - default: false, - renderTrigger: true, - description: t('Whether to display the interactive data table'), - }, - }, - { - name: 'include_series', - config: { - type: 'CheckboxControl', - label: t('Include Series'), - renderTrigger: true, - default: false, - description: t('Include series name as an axis'), - }, - }, - ], - ['linear_color_scheme'], - ], - }, - ], -}; diff --git a/superset-frontend/src/setup/setupPlugins.ts b/superset-frontend/src/setup/setupPlugins.ts index 52d73a1df..1162e4783 100644 --- a/superset-frontend/src/setup/setupPlugins.ts +++ b/superset-frontend/src/setup/setupPlugins.ts @@ -33,7 +33,6 @@ import DeckScreengrid from '../explore/controlPanels/DeckScreengrid'; import EventFlow from '../explore/controlPanels/EventFlow'; import FilterBox from '../explore/controlPanels/FilterBox'; import PairedTtest from '../explore/controlPanels/PairedTtest'; -import Para from '../explore/controlPanels/Para'; import Separator from '../explore/controlPanels/Separator'; import TimeTable from '../explore/controlPanels/TimeTable'; @@ -46,7 +45,6 @@ export default function setupPlugins() { .registerValue('event_flow', EventFlow) .registerValue('filter_box', FilterBox) .registerValue('paired_ttest', PairedTtest) - .registerValue('para', Para) .registerValue('separator', Separator) .registerValue('time_table', TimeTable) .registerValue('deck_arc', DeckArc)