From 274420bc5a30b63ba9f015ed11221ca679a115bb Mon Sep 17 00:00:00 2001
From: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Date: Tue, 17 Nov 2020 02:13:37 +0100
Subject: [PATCH] Fix ModalTriggers styling in SqlLab (#11719)

---
 superset-frontend/src/common/components/index.tsx | 8 ++++++++
 superset-frontend/src/components/ModalTrigger.jsx | 4 ++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/src/common/components/index.tsx b/superset-frontend/src/common/components/index.tsx
index f8f611173..dbf2a3178 100644
--- a/superset-frontend/src/common/components/index.tsx
+++ b/superset-frontend/src/common/components/index.tsx
@@ -53,6 +53,14 @@ export const MenuItem = styled(AntdMenu.Item)`
     height: ${({ theme }) => theme.gridUnit * 7}px;
     line-height: ${({ theme }) => theme.gridUnit * 7}px;
   }
+
+  &.ant-menu-item,
+  &.ant-dropdown-menu-item {
+    span[role='button'] {
+      display: inline-block;
+      width: 100%;
+    }
+  }
 `;
 
 export const Menu = Object.assign(AntdMenu, {
diff --git a/superset-frontend/src/components/ModalTrigger.jsx b/superset-frontend/src/components/ModalTrigger.jsx
index 69f26d42c..ddcc5744e 100644
--- a/superset-frontend/src/components/ModalTrigger.jsx
+++ b/superset-frontend/src/components/ModalTrigger.jsx
@@ -102,9 +102,9 @@ export default class ModalTrigger extends React.Component {
     /* eslint-disable jsx-a11y/interactive-supports-focus */
     return (
       <>
-        <div onClick={this.open} role="button">
+        <span onClick={this.open} role="button">
           {this.props.triggerNode}
-        </div>
+        </span>
         {this.renderModal()}
       </>
     );