chore: remove unused codes for samples (#20272)

This commit is contained in:
Yongjie Zhao 2022-06-07 21:54:15 +08:00 committed by GitHub
parent b110581b96
commit 27c3ef1ed5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 9 deletions

View File

@ -27,6 +27,7 @@ assists people when migrating to a new version.
- [19046](https://github.com/apache/superset/pull/19046): Enables the drag and drop interface in Explore control panel by default. Flips `ENABLE_EXPLORE_DRAG_AND_DROP` and `ENABLE_DND_WITH_CLICK_UX` feature flags to `True`.
- [18936](https://github.com/apache/superset/pull/18936): Removes legacy SIP-15 interim logic/flags—specifically the `SIP_15_ENABLED`, `SIP_15_GRACE_PERIOD_END`, `SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS`, and `SIP_15_TOAST_MESSAGE` flags. Time range endpoints are no longer configurable and strictly adhere to the `[start, end)` paradigm, i.e., inclusive of the start and exclusive of the end. Additionally this change removes the now obsolete `time_range_endpoints` from the form-data and resulting in the cache being busted.
- [19570](https://github.com/apache/superset/pull/19570): makes [sqloxide](https://pypi.org/project/sqloxide/) optional so the SIP-68 migration can be run on aarch64. If the migration is taking too long installing sqloxide manually should improve the performance.
- [20170](https://github.com/apache/superset/pull/20170): Introduced a new endpoint for getting datasets samples.
### Breaking Changes

View File

@ -26,7 +26,6 @@ import {
getChartBuildQueryRegistry,
getChartMetadataRegistry,
} from '@superset-ui/core';
import { omit } from 'lodash';
import { availableDomains } from 'src/utils/hostNamesConfig';
import { safeStringify } from 'src/utils/safeStringify';
import { URL_PARAMS } from 'src/constants';
@ -216,7 +215,7 @@ export const buildV1ChartDataPayload = ({
...baseQueryObject,
},
]));
const payload = buildQuery(
return buildQuery(
{
...formData,
force,
@ -230,13 +229,6 @@ export const buildV1ChartDataPayload = ({
},
},
);
if (resultType === 'samples') {
// remove row limit and offset to fall back to defaults
payload.queries = payload.queries.map(query =>
omit(query, ['row_limit', 'row_offset']),
);
}
return payload;
};
export const getLegacyEndpointType = ({ resultType, resultFormat }) =>