diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js index 8aafe0bad..0a3b7aa99 100644 --- a/superset-frontend/.eslintrc.js +++ b/superset-frontend/.eslintrc.js @@ -90,7 +90,6 @@ module.exports = { 'import/no-named-as-default-member': 0, 'import/prefer-default-export': 0, indent: 0, - 'jsx-a11y/anchor-has-content': 0, 'jsx-a11y/anchor-is-valid': 0, // disabled temporarily 'jsx-a11y/click-events-have-key-events': 0, // re-enable up for discussion 'jsx-a11y/mouse-events-have-key-events': 0, // re-enable up for discussion @@ -205,7 +204,6 @@ module.exports = { 'import/no-named-as-default': 0, 'import/prefer-default-export': 0, indent: 0, - 'jsx-a11y/anchor-has-content': 0, 'jsx-a11y/anchor-is-valid': 0, // disabled temporarily 'jsx-a11y/click-events-have-key-events': 0, // re-enable up for discussion 'jsx-a11y/mouse-events-have-key-events': 0, // re-enable up for discussion diff --git a/superset-frontend/spec/javascripts/explore/components/ControlRow_spec.jsx b/superset-frontend/spec/javascripts/explore/components/ControlRow_spec.jsx index 975b96737..1c556c4f5 100644 --- a/superset-frontend/spec/javascripts/explore/components/ControlRow_spec.jsx +++ b/superset-frontend/spec/javascripts/explore/components/ControlRow_spec.jsx @@ -22,11 +22,13 @@ import ControlSetRow from 'src/explore/components/ControlRow'; describe('ControlSetRow', () => { it('renders a single row with one element', () => { + // eslint-disable-next-line jsx-a11y/anchor-has-content const wrapper = shallow(]} />); expect(wrapper.find('.row')).toExist(); expect(wrapper.find('.row').find('a')).toExist(); }); it('renders a single row with two elements', () => { + // eslint-disable-next-line jsx-a11y/anchor-has-content const wrapper = shallow(, ]} />); expect(wrapper.find('.row')).toExist(); expect(wrapper.find('.row').find('a')).toHaveLength(2); diff --git a/superset-frontend/src/SqlLab/components/TableElement.jsx b/superset-frontend/src/SqlLab/components/TableElement.jsx index 5594f4194..c65afd476 100644 --- a/superset-frontend/src/SqlLab/components/TableElement.jsx +++ b/superset-frontend/src/SqlLab/components/TableElement.jsx @@ -170,7 +170,11 @@ class TableElement extends React.PureComponent { /> {table.selectStar && ( } + copyNode={ + + + + } text={table.selectStar} shouldShowText={false} tooltipText={t('Copy SELECT statement to the clipboard')}