diff --git a/superset/databases/api.py b/superset/databases/api.py index f1d3f34db..40980dc87 100644 --- a/superset/databases/api.py +++ b/superset/databases/api.py @@ -871,7 +871,7 @@ class DatabaseRestApi(BaseSupersetModelRestApi): self.incr_stats("init", self.select_star.__name__) try: result = database.select_star( - table_name, schema_name, latest_partition=True, show_cols=True + table_name, schema_name, latest_partition=True ) except NoSuchTableError: self.incr_stats("error", self.select_star.__name__) diff --git a/superset/databases/utils.py b/superset/databases/utils.py index 21abd7b9c..8de4bb6f2 100644 --- a/superset/databases/utils.py +++ b/superset/databases/utils.py @@ -92,7 +92,6 @@ def get_table_metadata( "selectStar": database.select_star( table_name, schema=schema_name, - show_cols=True, indent=True, cols=columns, latest_partition=True, diff --git a/tests/integration_tests/databases/api_tests.py b/tests/integration_tests/databases/api_tests.py index 249b95396..7f65c5bd4 100644 --- a/tests/integration_tests/databases/api_tests.py +++ b/tests/integration_tests/databases/api_tests.py @@ -1480,7 +1480,7 @@ class TestDatabaseApi(SupersetTestCase): "indexes": [], "name": "wrong_table", "primaryKey": {"constrained_columns": None, "name": None}, - "selectStar": "SELECT\nFROM wrong_table\nLIMIT 100\nOFFSET 0", + "selectStar": "SELECT\n *\nFROM wrong_table\nLIMIT 100\nOFFSET 0", }, ) elif example_db.backend == "mysql": @@ -1550,8 +1550,6 @@ class TestDatabaseApi(SupersetTestCase): uri = f"api/v1/database/{example_db.id}/select_star/birth_names/" rv = self.client.get(uri) self.assertEqual(rv.status_code, 200) - response = json.loads(rv.data.decode("utf-8")) - self.assertIn("gender", response["result"]) def test_get_select_star_not_allowed(self): """