iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove feature flag for tags on Dashboard API for `Tags` (#23909)

This commit is contained in:
Hugh A. Miles II 2023-05-02 17:02:42 -04:00 committed by GitHub
parent a8e02cd851
commit 3528f4140c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
superset/dashboards/api.py
View File

@ -191,9 +191,11 @@ class DashboardRestApi(BaseSupersetModelRestApi):
"roles.id",
"roles.name",
"is_managed_externally",
"tags.id",
"tags.name",
"tags.type",
]
if is_feature_enabled("TAGGING_SYSTEM"):
list_columns += ["tags.id", "tags.name", "tags.type"]
list_select_columns = list_columns + ["changed_on", "created_on", "changed_by_fk"]
order_columns = [
"changed_by.first_name",
@ -219,36 +221,22 @@ class DashboardRestApi(BaseSupersetModelRestApi):
edit_columns = add_columns
search_columns = (
(
"created_by",
"changed_by",
"dashboard_title",
"id",
"owners",
"published",
"roles",
"slug",
"tags",
)
if is_feature_enabled("TAGGING_SYSTEM")
else (
"created_by",
"changed_by",
"dashboard_title",
"id",
"owners",
"published",
"roles",
"slug",
)
"created_by",
"changed_by",
"dashboard_title",
"id",
"owners",
"published",
"roles",
"slug",
"tags",
)
search_filters = {
"dashboard_title": [DashboardTitleOrSlugFilter],
"id": [DashboardFavoriteFilter, DashboardCertifiedFilter],
"created_by": [DashboardCreatedByMeFilter, DashboardHasCreatedByFilter],
"tags": [DashboardTagFilter],
}
if is_feature_enabled("TAGGING_SYSTEM"):
search_filters["tags"] = [DashboardTagFilter]
base_order = ("changed_on", "desc")