iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Removing the logic to add timeseries_limit_metric to the data for table (#9832) 

* Removing the logic to add timeseries_limit_metric to the data for table viz

* Also make the change in viz_sip_38

* Fix tests

Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com>
This commit is contained in:
michellethomas 2020-05-20 10:20:54 -07:00 committed by GitHub
parent c691a07948
commit 368c85de1b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
superset/viz.py
View File

@ -637,12 +637,6 @@ class TableViz(BaseViz):
utils.get_metric_names(self.form_data.get("metrics") or [])
)
timeseries_limit_metric = utils.get_metric_name(
self.form_data.get("timeseries_limit_metric")
)
if timeseries_limit_metric:
non_percent_metric_columns.append(timeseries_limit_metric)
percent_metric_columns = utils.get_metric_names(
self.form_data.get("percent_metrics") or []
)

6
superset/viz_sip38.py
View File

@ -676,12 +676,6 @@ class TableViz(BaseViz):
utils.get_metric_names(self.form_data.get("metrics") or [])
)
timeseries_limit_metric = utils.get_metric_name(
self.form_data.get("timeseries_limit_metric")
)
if timeseries_limit_metric:
non_percent_metric_columns.append(timeseries_limit_metric)
percent_metric_columns = utils.get_metric_names(
self.form_data.get("percent_metrics") or []
)

2
tests/viz_tests.py
View File

@ -431,7 +431,7 @@ class TableVizTestCase(SupersetTestCase):
datasource = self.get_datasource_mock()
test_viz = viz.TableViz(datasource, form_data)
data = test_viz.get_data(df)
self.assertEqual(["sum_value", "SUM(value1)"], data["columns"])
self.assertEqual(["sum_value"], data["columns"])
class DistBarVizTestCase(SupersetTestCase):