From 3a249a00908e605cd3133af6fc7eafefb7fe093d Mon Sep 17 00:00:00 2001 From: AAfghahi <48933336+AAfghahi@users.noreply.github.com> Date: Mon, 19 Jul 2021 14:47:33 -0400 Subject: [PATCH] feat: add show columns to Reports model (#15712) * added logic for creation_method * revisions * added index * Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py * filters * search columns updated --- superset/reports/api.py | 3 +++ tests/integration_tests/reports/api_tests.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/superset/reports/api.py b/superset/reports/api.py index ccbda74b1..03d72bc6f 100644 --- a/superset/reports/api.py +++ b/superset/reports/api.py @@ -182,6 +182,9 @@ class ReportScheduleRestApi(BaseSupersetModelRestApi): "created_by", "type", "last_state", + "creation_method", + "dashboard_id", + "chart_id", ] search_filters = {"name": [ReportScheduleAllTextFilter]} allowed_rel_fields = {"owners", "chart", "dashboard", "database", "created_by"} diff --git a/tests/integration_tests/reports/api_tests.py b/tests/integration_tests/reports/api_tests.py index 1fe71065f..06888e98a 100644 --- a/tests/integration_tests/reports/api_tests.py +++ b/tests/integration_tests/reports/api_tests.py @@ -773,7 +773,7 @@ class TestReportSchedulesApi(SupersetTestCase): data = json.loads(rv.data.decode("utf-8")) assert data == {"message": {"dashboard": "Dashboard does not exist"}} - @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices") + # @pytest.mark.usefixtures("load_birth_names_dashboard_with_slices") # TODO (AAfghahi): I am going to enable this when the report schedule feature is fully finished # def test_create_report_schedule_no_creation_method(self): # """