diff --git a/superset-frontend/src/components/ReportModal/index.tsx b/superset-frontend/src/components/ReportModal/index.tsx index dd2771c62..7ec468191 100644 --- a/superset-frontend/src/components/ReportModal/index.tsx +++ b/superset-frontend/src/components/ReportModal/index.tsx @@ -126,7 +126,12 @@ type ReportActionType = }; const DEFAULT_NOTIFICATION_FORMAT = 'TEXT'; -const TEXT_BASED_VISUALIZATION_TYPES: string[] = []; +const TEXT_BASED_VISUALIZATION_TYPES = [ + 'pivot_table', + 'pivot_table_v2', + 'table', + 'paired_ttest', +]; const reportReducer = ( state: Partial | null, diff --git a/superset-frontend/src/views/CRUD/alert/AlertReportModal.test.jsx b/superset-frontend/src/views/CRUD/alert/AlertReportModal.test.jsx index cc9bdc0a0..8575a526a 100644 --- a/superset-frontend/src/views/CRUD/alert/AlertReportModal.test.jsx +++ b/superset-frontend/src/views/CRUD/alert/AlertReportModal.test.jsx @@ -260,6 +260,22 @@ describe('AlertReportModal', () => { expect(wrapper.find(Radio)).toHaveLength(2); }); + it('renders text option for text-based charts', async () => { + const props = { + ...mockedProps, + alert: mockData, + }; + const textWrapper = await mountAndWait(props); + + const chartOption = textWrapper.find('input[value="chart"]'); + act(() => { + chartOption.props().onChange({ target: { value: 'chart' } }); + }); + await waitForComponentToPaint(textWrapper); + + expect(textWrapper.find('input[value="TEXT"]')).toExist(); + }); + it('renders input element for working timeout', () => { expect(wrapper.find('input[name="working_timeout"]')).toExist(); }); diff --git a/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx b/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx index f4ff05bfb..c39783ebb 100644 --- a/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx +++ b/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx @@ -52,7 +52,12 @@ import { const SELECT_PAGE_SIZE = 2000; // temporary fix for paginated query const TIMEOUT_MIN = 1; -const TEXT_BASED_VISUALIZATION_TYPES: string[] = []; +const TEXT_BASED_VISUALIZATION_TYPES = [ + 'pivot_table', + 'pivot_table_v2', + 'table', + 'paired_ttest', +]; type SelectValue = { value: string;