iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[fix] edit chart title cause JS error (#6438)

This commit is contained in:
Grace Guo 2018-11-27 10:36:56 -08:00 committed by GitHub
parent 1eb0d0d835
commit 3e4742fa7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset/assets/src/dashboard/actions/datasources.js
View File

@ -28,7 +28,7 @@ export function fetchDatasourceMetadata(key) {
return SupersetClient.get({
endpoint: `/superset/fetch_datasource_metadata?datasourceKey=${key}`,
})
.then(data => dispatch(data, key))
.then(data => dispatch(setDatasource(data, key)))
.catch(response =>
getClientErrorObject(response).then(({ error }) =>
dispatch(fetchDatasourceFailed(error, key)),

3
superset/assets/src/explore/components/ExploreChartHeader.jsx
View File

@ -44,7 +44,8 @@ class ExploreChartHeader extends React.PureComponent {
action: isNewSlice ? 'saveas' : 'overwrite',
};
this.props.actions.saveSlice(this.props.form_data, params)
.then((data) => {
.then((json) => {
const { data } = json;
if (isNewSlice) {
this.props.actions.createNewSlice(
data.can_add, data.can_download, data.can_overwrite,

3
superset/assets/src/explore/components/ExploreViewContainer.jsx
View File

@ -15,6 +15,7 @@ import { chartPropShape } from '../../dashboard/util/propShapes';
import * as exploreActions from '../actions/exploreActions';
import * as saveModalActions from '../actions/saveModalActions';
import * as chartActions from '../../chart/chartAction';
import { fetchDatasourceMetadata } from '../../dashboard/actions/datasources';
import { Logger, ActionLog, EXPLORE_EVENT_NAMES, LOG_ACTIONS_MOUNT_EXPLORER } from '../../logger';
const propTypes = {
@ -81,7 +82,7 @@ class ExploreViewContainer extends React.Component {
(this.props.controls.datasource == null ||
nextProps.controls.datasource.value !== this.props.controls.datasource.value)
) {
this.props.actions.fetchDatasourceMetadata(nextProps.form_data.datasource, true);
fetchDatasourceMetadata(nextProps.form_data.datasource, true);
}
const changedControlKeys = this.findChangedControlKeys(this.props.controls, nextProps.controls);