iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Convert TIMESTAMP_* to TIMESTAMP in Snowflake (#22872)

This commit is contained in:
Geido 2023-01-26 19:49:44 +01:00 committed by GitHub
parent 6998f65e1d
commit 3fd4718ecb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
View File

@ -334,7 +334,7 @@ class AnnotationLayer extends React.PureComponent {
...x,
data: {
...x.data,
groupby: x.data.groupby.map(column =>
groupby: x.data.groupby?.map(column =>
getColumnLabel(column),
),
},

2
superset/db_engine_specs/snowflake.py
View File

@ -162,7 +162,7 @@ class SnowflakeEngineSpec(PostgresBaseEngineSpec):
return f"TO_DATE('{dttm.date().isoformat()}')"
if tt == utils.TemporalType.DATETIME:
return f"""CAST('{dttm.isoformat(timespec="microseconds")}' AS DATETIME)"""
if tt == utils.TemporalType.TIMESTAMP:
if utils.TemporalType.TIMESTAMP in tt:
return f"""TO_TIMESTAMP('{dttm.isoformat(timespec="microseconds")}')"""
return None

1
tests/unit_tests/db_engine_specs/test_snowflake.py
View File

@ -34,6 +34,7 @@ from tests.unit_tests.fixtures.common import dttm
("DATE", "TO_DATE('2019-01-02')"),
("DATETIME", "CAST('2019-01-02T03:04:05.678900' AS DATETIME)"),
("TIMESTAMP", "TO_TIMESTAMP('2019-01-02T03:04:05.678900')"),
("TIMESTAMP_NTZ", "TO_TIMESTAMP('2019-01-02T03:04:05.678900')"),
],
)
def test_convert_dttm(actual: str, expected: str, dttm: datetime) -> None: