From 43ee52be57e06d4277bf07c852c58b6c8dea30db Mon Sep 17 00:00:00 2001
From: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Date: Wed, 28 Apr 2021 11:41:22 +0300
Subject: [PATCH] fix(native-filters): force update control value on change
 (#14385)

* fix(native-filters): force update control value on change

* fix test
---
 .../FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx  | 2 +-
 .../FiltersConfigModal/FiltersConfigForm/ControlItems.tsx       | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx
index 5232a698d..04cfe503c 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.test.tsx
@@ -123,6 +123,6 @@ test('Clickin on checkbox when resetConfig:flase', () => {
   expect(props.forceUpdate).not.toBeCalled();
   expect(setNativeFilterFieldValues).not.toBeCalled();
   userEvent.click(screen.getByRole('checkbox'));
-  expect(props.forceUpdate).not.toBeCalled();
+  expect(props.forceUpdate).toBeCalled();
   expect(setNativeFilterFieldValues).not.toBeCalled();
 });
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx
index 48c074cc2..4310a5b45 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ControlItems.tsx
@@ -72,6 +72,7 @@ const ControlItems: FC<ControlItemsProps> = ({
             <Checkbox
               onChange={() => {
                 if (!controlItem.config.resetConfig) {
+                  forceUpdate();
                   return;
                 }
                 setNativeFilterFieldValues(form, filterId, {