iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(explore): make to convert null to N/A in view results (#19316) 

* fix(explore): make to convert null to N/A in view results

* fix(explore): make to null formatter move before timeFormatter
This commit is contained in:
smileydev 2022-03-23 10:02:52 -04:00 committed by GitHub
parent 9e58916d93
commit 468c5ca29a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
superset-frontend/src/constants.ts
View File

@ -102,3 +102,8 @@ export const FAST_DEBOUNCE = 250;
* Slower debounce delay for inputs with expensive API calls. * Slower debounce delay for inputs with expensive API calls.
*/ */
export const SLOW_DEBOUNCE = 500; export const SLOW_DEBOUNCE = 500;
/**
* Display null as `N/A`
*/
export const NULL_DISPLAY = 'N/A';

8
superset-frontend/src/explore/components/DataTableControl/index.tsx
View File

@ -36,6 +36,7 @@ import {
BOOL_FALSE_DISPLAY, BOOL_FALSE_DISPLAY,
BOOL_TRUE_DISPLAY, BOOL_TRUE_DISPLAY,
SLOW_DEBOUNCE, SLOW_DEBOUNCE,
NULL_DISPLAY,
} from 'src/constants'; } from 'src/constants';
import { Radio } from 'src/components/Radio'; import { Radio } from 'src/components/Radio';
import Icons from 'src/components/Icons'; import Icons from 'src/components/Icons';
@ -49,6 +50,10 @@ import {
unsetTimeFormattedColumn, unsetTimeFormattedColumn,
} from 'src/explore/actions/exploreActions'; } from 'src/explore/actions/exploreActions';
export const CellNull = styled('span')`
color: ${({ theme }) => theme.colors.grayscale.light1};
`;
export const CopyButton = styled(Button)` export const CopyButton = styled(Button)`
font-size: ${({ theme }) => theme.typography.sizes.s}px; font-size: ${({ theme }) => theme.typography.sizes.s}px;
@ -303,6 +308,9 @@ export const useTableColumns = (
if (value === false) { if (value === false) {
return BOOL_FALSE_DISPLAY; return BOOL_FALSE_DISPLAY;
} }
if (value === null) {
return <CellNull>{NULL_DISPLAY}</CellNull>;
}
if (timeFormattedColumnIndex > -1) { if (timeFormattedColumnIndex > -1) {
return timeFormatter(value); return timeFormatter(value);
} }