From 47be3ef3ea385925b5ef67cdecb0ba36adc2b3db Mon Sep 17 00:00:00 2001
From: Maxime Beauchemin <maximebeauchemin@gmail.com>
Date: Mon, 27 Feb 2017 17:07:10 -0800
Subject: [PATCH] Fixing bugs in Sankey diagrams (#2290)

* NULL values for name breaks the chart
* negative rect svg height values
---
 superset/assets/visualizations/sankey.js | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/superset/assets/visualizations/sankey.js b/superset/assets/visualizations/sankey.js
index e80fd6996..0a015e78b 100644
--- a/superset/assets/visualizations/sankey.js
+++ b/superset/assets/visualizations/sankey.js
@@ -132,14 +132,13 @@ function sankeyVis(slice, payload) {
       })
       .on('drag', dragmove)
     );
-
+  const minRectHeight = 5;
   node.append('rect')
-    .attr('height', function (d) {
-      return d.dy;
-    })
+    .attr('height', d => d.dy > minRectHeight ? d.dy : minRectHeight)
     .attr('width', sankey.nodeWidth())
     .style('fill', function (d) {
-      d.color = category21(d.name.replace(/ .*/, ''));
+      const name = d.name || 'N/A';
+      d.color = category21(name.replace(/ .*/, ''));
       return d.color;
     })
     .style('stroke', function (d) {