iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(pinot): typo in the name for epoch_ms_to_dttm (#26906)

This commit is contained in:
Erich 2024-01-30 23:49:55 -05:00 committed by GitHub
parent 73d118c0e2
commit 484901f483
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset/db_engine_specs/pinot.py
View File

@ -62,7 +62,7 @@ class PinotEngineSpec(BaseEngineSpec):
) )
@classmethod @classmethod
def epoch_ms_to_dttm_(cls) -> str: def epoch_ms_to_dttm(cls) -> str:
return ( return (
"DATETIMECONVERT({col}, '1:MILLISECONDS:EPOCH', " "DATETIMECONVERT({col}, '1:MILLISECONDS:EPOCH', "
+ "'1:MILLISECONDS:EPOCH', '1:MILLISECONDS')" + "'1:MILLISECONDS:EPOCH', '1:MILLISECONDS')"

14
tests/integration_tests/db_engine_specs/pinot_tests.py
View File

@ -84,6 +84,20 @@ class TestPinotDbEngineSpec(TestDbEngineSpec):
expected, expected,
) )
def test_pinot_time_expression_millisec_one_1m_grain(self):
col = column("tstamp")
expr = PinotEngineSpec.get_timestamp_expr(col, "epoch_ms", "P1M")
result = str(expr.compile())
expected = (
"CAST(DATE_TRUNC('month', CAST("
+ "DATETIMECONVERT(tstamp, '1:MILLISECONDS:EPOCH', "
+ "'1:MILLISECONDS:EPOCH', '1:MILLISECONDS') AS TIMESTAMP)) AS TIMESTAMP)"
)
self.assertEqual(
result,
expected,
)
def test_invalid_get_time_expression_arguments(self): def test_invalid_get_time_expression_arguments(self):
with self.assertRaises(NotImplementedError): with self.assertRaises(NotImplementedError):
PinotEngineSpec.get_timestamp_expr(column("tstamp"), None, "P0.25Y") PinotEngineSpec.get_timestamp_expr(column("tstamp"), None, "P0.25Y")