chore: add eslint to pre-commit hooks (#31845)
This commit is contained in:
parent
ffb6913706
commit
4bad1a258f
|
|
@ -41,6 +41,8 @@ jobs:
|
||||||
- name: pre-commit
|
- name: pre-commit
|
||||||
run: |
|
run: |
|
||||||
set +e # Don't exit immediately on failure
|
set +e # Don't exit immediately on failure
|
||||||
|
# Skip eslint as it requires `npm ci` and is executed in another job
|
||||||
|
export SKIP=eslint
|
||||||
pre-commit run --all-files
|
pre-commit run --all-files
|
||||||
if [ $? -ne 0 ] || ! git diff --quiet --exit-code; then
|
if [ $? -ne 0 ] || ! git diff --quiet --exit-code; then
|
||||||
echo "❌ Pre-commit check failed."
|
echo "❌ Pre-commit check failed."
|
||||||
|
|
|
||||||
|
|
@ -52,6 +52,14 @@ repos:
|
||||||
- id: trailing-whitespace
|
- id: trailing-whitespace
|
||||||
exclude: ^.*\.(snap)
|
exclude: ^.*\.(snap)
|
||||||
args: ["--markdown-linebreak-ext=md"]
|
args: ["--markdown-linebreak-ext=md"]
|
||||||
|
- repo: local
|
||||||
|
hooks:
|
||||||
|
- id: eslint
|
||||||
|
name: eslint
|
||||||
|
entry: bash -c 'cd superset-frontend && npm run eslint -- $(echo "$@" | sed "s|superset-frontend/||g")'
|
||||||
|
language: system
|
||||||
|
pass_filenames: true
|
||||||
|
files: \.(js|jsx|ts|tsx)$
|
||||||
- repo: https://github.com/pre-commit/mirrors-prettier
|
- repo: https://github.com/pre-commit/mirrors-prettier
|
||||||
rev: v4.0.0-alpha.8 # Use the sha or tag you want to point at
|
rev: v4.0.0-alpha.8 # Use the sha or tag you want to point at
|
||||||
hooks:
|
hooks:
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue