iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: revert fix(presto preview): re-enable schema previsualization for Trino/Presto table/schemas" (#28613)

This commit is contained in:
John Bodley 2024-05-21 11:23:32 -07:00 committed by GitHub
parent 62a0336425
commit 4fa7619b1f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
superset/db_engine_specs/presto.py
View File

@ -536,10 +536,7 @@ class PrestoBaseEngineSpec(BaseEngineSpec, metaclass=ABCMeta):
}
for col_name, value in zip(col_names, values):
col_type = None
if col_type_name := column_type_by_name.get(col_name):
if col_type_class := getattr(types, col_type_name, None):
col_type = col_type_class()
col_type = column_type_by_name.get(col_name)
if isinstance(col_type, types.DATE):
col_type = Date()

8
tests/unit_tests/db_engine_specs/test_presto.py
View File

@ -116,10 +116,10 @@ def test_get_schema_from_engine_params() -> None:
@pytest.mark.parametrize(
["column_type", "column_value", "expected_value"],
[
("DATE", "2023-05-01", "DATE '2023-05-01'"),
("TIMESTAMP", "2023-05-01", "TIMESTAMP '2023-05-01'"),
("VARCHAR", "2023-05-01", "'2023-05-01'"),
("INT", 1234, "1234"),
(types.DATE(), "2023-05-01", "DATE '2023-05-01'"),
(types.TIMESTAMP(), "2023-05-01", "TIMESTAMP '2023-05-01'"),
(types.VARCHAR(), "2023-05-01", "'2023-05-01'"),
(types.INT(), 1234, "1234"),
],
)
def test_where_latest_partition(