iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Improving handling for tag relationship when deleting assets v2 (#29229)

This commit is contained in:
Vitor Avila 2024-06-12 13:39:34 -03:00 committed by GitHub
parent a067ffb92d
commit 5167d20f27
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
superset/models/dashboard.py
View File

@ -154,8 +154,8 @@ class Dashboard(AuditMixinNullable, ImportExportMixin, Model):
secondary="tagged_object", secondary="tagged_object",
primaryjoin="and_(Dashboard.id == TaggedObject.object_id, " primaryjoin="and_(Dashboard.id == TaggedObject.object_id, "
"TaggedObject.object_type == 'dashboard')", "TaggedObject.object_type == 'dashboard')",
secondaryjoin="and_(TaggedObject.tag_id == Tag.id)", secondaryjoin="TaggedObject.tag_id == Tag.id",
passive_deletes=True, viewonly=True, # cascading deletion already handled by superset.tags.models.ObjectUpdater.after_delete
) )
published = Column(Boolean, default=False) published = Column(Boolean, default=False)
is_managed_externally = Column(Boolean, nullable=False, default=False) is_managed_externally = Column(Boolean, nullable=False, default=False)

4
superset/models/slice.py
View File

@ -106,8 +106,8 @@ class Slice( # pylint: disable=too-many-public-methods
overlaps="objects,tag,tags", overlaps="objects,tag,tags",
primaryjoin="and_(Slice.id == TaggedObject.object_id, " primaryjoin="and_(Slice.id == TaggedObject.object_id, "
"TaggedObject.object_type == 'chart')", "TaggedObject.object_type == 'chart')",
secondaryjoin="and_(TaggedObject.tag_id == Tag.id)", secondaryjoin="TaggedObject.tag_id == Tag.id",
passive_deletes=True, viewonly=True, # cascading deletion already handled by superset.tags.models.ObjectUpdater.after_delete
) )
table = relationship( table = relationship(
"SqlaTable", "SqlaTable",

4
superset/models/sql_lab.py
View File

@ -418,8 +418,8 @@ class SavedQuery(
overlaps="objects,tag,tags", overlaps="objects,tag,tags",
primaryjoin="and_(SavedQuery.id == TaggedObject.object_id, " primaryjoin="and_(SavedQuery.id == TaggedObject.object_id, "
"TaggedObject.object_type == 'query')", "TaggedObject.object_type == 'query')",
secondaryjoin="and_(TaggedObject.tag_id == Tag.id)", secondaryjoin="TaggedObject.tag_id == Tag.id",
passive_deletes=True, viewonly=True, # cascading deletion already handled by superset.tags.models.ObjectUpdater.after_delete
) )
export_parent = "database" export_parent = "database"