chore: allow codecov to detect SHA (#28278)

.github/workflows/bashlib.sh

@@ -117,12 +117,6 @@ testdata() {
   say "::endgroup::"
 }
 
-codecov() {
-  say "::group::Upload code coverage"
-  bash ".github/workflows/codecov.sh" "$@"
-  say "::endgroup::"
-}
-
 cypress-install() {
   cd "$GITHUB_WORKSPACE/superset-frontend/cypress-base"
 
@@ -191,11 +185,6 @@ cypress-run-all() {
 
   cypress-run "sqllab/*" "Backend persist"
 
-  # Upload code coverage separately so each page can have separate flags
-  # -c will clean existing coverage reports, -F means add flags
-  # || true to prevent CI failure on codecov upload
-  codecov -c -F "cypress" || true
-
   say "::group::Flask log for backend persist"
   cat "$flasklog"
   say "::endgroup::"
@@ -225,8 +214,6 @@ cypress-run-applitools() {
 
   $cypress --spec "cypress/e2e/*/**/*.applitools.test.ts" --browser "$browser" --headless
 
-  codecov -c -F "cypress" || true
-
   say "::group::Flask log for default run"
   cat "$flasklog"
   say "::endgroup::"

.github/workflows/superset-frontend.yml

@@ -20,7 +20,6 @@ jobs:
       - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
         uses: actions/checkout@v4
         with:
-          fetch-depth: 0 # Fetch all history
           persist-credentials: false
           submodules: recursive
       - name: Check npm lock file version
@@ -79,8 +78,8 @@ jobs:
         working-directory: ./superset-frontend/packages/generator-superset
         run: npx jest
       - name: Upload code coverage
-        if: steps.check.outputs.frontend
+        uses: codecov/codecov-action@v4
-        working-directory: ./superset-frontend
+        with:
-        run: ../.github/workflows/codecov.sh -c -F javascript
+          flags: javascript
-        env:
+          token: ${{ secrets.CODECOV_TOKEN }}
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true

.github/workflows/superset-python-integrationtest.yml

@@ -66,9 +66,11 @@ jobs:
         run: |
           ./scripts/python_tests.sh
       - name: Upload code coverage
-        if: steps.check.outputs.python
+        uses: codecov/codecov-action@v4
-        run: |
+        with:
-          bash .github/workflows/codecov.sh -c -F python -F mysql
+          flags: python,mysql
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true
   test-postgres:
     runs-on: ubuntu-20.04
     strategy:
@@ -123,9 +125,11 @@ jobs:
         run: |
           ./scripts/python_tests.sh
       - name: Upload code coverage
-        if: steps.check.outputs.python
+        uses: codecov/codecov-action@v4
-        run: |
+        with:
-          bash .github/workflows/codecov.sh -c -F python -F postgres
+          flags: python,postgres
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true
 
   test-sqlite:
     runs-on: ubuntu-20.04
@@ -171,6 +175,8 @@ jobs:
         run: |
           ./scripts/python_tests.sh
       - name: Upload code coverage
-        if: steps.check.outputs.python
+        uses: codecov/codecov-action@v4
-        run: |
+        with:
-          bash .github/workflows/codecov.sh -c -F python -F sqlite
+          flags: python,sqlite
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true

.github/workflows/superset-python-presto-hive.yml

@@ -75,9 +75,11 @@ jobs:
         run: |
           ./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow'
       - name: Upload code coverage
-        if: steps.check.outputs.python
+        uses: codecov/codecov-action@v4
-        run: |
+        with:
-          bash .github/workflows/codecov.sh -c -F python -F presto
+          flags: python,presto
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true
 
   test-postgres-hive:
     runs-on: ubuntu-20.04
@@ -138,6 +140,8 @@ jobs:
         run: |
           ./scripts/python_tests.sh -m 'chart_data_flow or sql_json_flow'
       - name: Upload code coverage
-        if: steps.check.outputs.python
+        uses: codecov/codecov-action@v4
-        run: |
+        with:
-          bash .github/workflows/codecov.sh -c -F python -F hive
+          flags: python,hive
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true

.github/workflows/superset-python-unittest.yml

@@ -46,6 +46,8 @@ jobs:
         run: |
           pytest --durations-min=0.5 --cov-report= --cov=superset ./tests/common ./tests/unit_tests --cache-clear
       - name: Upload code coverage
-        if: steps.check.outputs.python
+        uses: codecov/codecov-action@v4
-        run: |
+        with:
-          bash .github/workflows/codecov.sh -c -F python -F unit
+          flags: python,unit
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true