iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(dashboard): add toast if JSON metadata is invalid (#20823)

This commit is contained in:
Stephen Liu 2022-07-23 14:14:28 +08:00 committed by GitHub
parent 3fb5c79d77
commit 557cf4b739
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx
View File

@ -59,6 +59,7 @@ type PropertiesModalProps = {
setColorSchemeAndUnsavedChanges?: () => void;
onSubmit?: (params: Record<string, any>) => void;
addSuccessToast: (message: string) => void;
addDangerToast: (message: string) => void;
onlyApply?: boolean;
};
@ -80,6 +81,7 @@ type DashboardInfo = {
const PropertiesModal = ({
addSuccessToast,
addDangerToast,
colorScheme: currentColorScheme,
dashboardId,
dashboardInfo: currentDashboardInfo,
@ -294,7 +296,12 @@ const PropertiesModal = ({
// color scheme in json metadata has precedence over selection
if (currentJsonMetadata?.length) {
const metadata = JSON.parse(currentJsonMetadata);
let metadata;
try {
metadata = JSON.parse(currentJsonMetadata);
} catch (error) {
addDangerToast(t('JSON metadata is invalid!'));
}
currentColorScheme = metadata?.color_scheme || colorScheme;
colorNamespace = metadata?.color_namespace || '';