From 593861eac65bee9a1106ed6de91a63d9ebdce7f3 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Wed, 21 Jun 2017 09:31:29 -0700 Subject: [PATCH] [bugfix] fix metrics/metric control default (#3009) We should pick an arbitrary metric by default. This broke when improving the metrics selector recently. --- superset/assets/javascripts/explore/stores/controls.jsx | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/superset/assets/javascripts/explore/stores/controls.jsx b/superset/assets/javascripts/explore/stores/controls.jsx index 87800b848..1e543a201 100644 --- a/superset/assets/javascripts/explore/stores/controls.jsx +++ b/superset/assets/javascripts/explore/stores/controls.jsx @@ -63,8 +63,7 @@ export const controls = { valueKey: 'metric_name', optionRenderer: m => , valueRenderer: m => , - default: control => - control.choices && control.choices.length > 0 ? [control.choices[0][0]] : null, + default: c => c.options && c.options.length > 0 ? [c.options[0].metric_name] : null, mapStateToProps: state => ({ options: (state.datasource) ? state.datasource.metrics : [], }), @@ -100,9 +99,8 @@ export const controls = { validators: [v.nonEmpty], optionRenderer: m => , valueRenderer: m => , + default: c => c.options && c.options.length > 0 ? c.options[0].metric_name : null, valueKey: 'metric_name', - default: control => - control.choices && control.choices.length > 0 ? control.choices[0][0] : null, mapStateToProps: state => ({ options: (state.datasource) ? state.datasource.metrics : [], }),