iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(alerts): flaky test error (#23860)

This commit is contained in:
JUST.in DO IT 2023-04-28 08:57:57 -07:00 committed by GitHub
parent 60046ca1cc
commit 594d3e0e0c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
superset-frontend/src/features/alerts/AlertReportModal.test.tsx
View File

@ -21,8 +21,15 @@ import { render, screen, waitFor } from 'spec/helpers/testing-library';
import userEvent from '@testing-library/user-event';
import AlertReportModal from './AlertReportModal';
jest.mock('src/components/AsyncAceEditor', () => ({
...jest.requireActual('src/components/AsyncAceEditor'),
TextAreaEditor: () => <div data-test="react-ace" />,
}));
const onHide = jest.fn();
test('allows change to None in log retention', async () => {
render(<AlertReportModal show />, { useRedux: true });
render(<AlertReportModal show onHide={onHide} />, { useRedux: true });
// open the log retention select
userEvent.click(screen.getByText('90 days'));
// change it to 30 days
@ -42,7 +49,7 @@ test('allows change to None in log retention', async () => {
});
test('renders the appropriate dropdown in Message Content section', async () => {
render(<AlertReportModal show />, { useRedux: true });
render(<AlertReportModal show onHide={onHide} />, { useRedux: true });
const chartRadio = screen.getByRole('radio', { name: /chart/i });
@ -62,7 +69,8 @@ test('renders the appropriate dropdown in Message Content section', async () =>
// Click the chart radio option
userEvent.click(chartRadio);
expect(await screen.findByRole('radio', { name: /chart/i })).toBeChecked();
await waitFor(() => expect(chartRadio).toBeChecked());
expect(
await screen.findByRole('radio', {
name: /dashboard/i,