iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: dashboard filter value is cleared when 2 similar dashboards opened in succession (#21461)

This commit is contained in:
Mayur 2022-09-14 17:11:51 +05:30 committed by GitHub
parent ae6d2cf18d
commit 59ca7861c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
View File

@ -250,6 +250,7 @@ const FilterBar: React.FC<FiltersBarProps> = ({
const dashboardId = useSelector<any, string>(
({ dashboardInfo }) => dashboardInfo?.id,
);
const previousDashboardId = usePrevious(dashboardId);
const canEdit = useSelector<RootState, boolean>(
({ dashboardInfo }) => dashboardInfo.dash_edit_perm,
);
@ -283,7 +284,7 @@ const FilterBar: React.FC<FiltersBarProps> = ({
);
useEffect(() => {
if (previousFilters) {
if (previousFilters && dashboardId === previousDashboardId) {
const updates = {};
Object.values(filters).forEach(currentFilter => {
const previousFilter = previousFilters?.[currentFilter.id];
@ -310,7 +311,11 @@ const FilterBar: React.FC<FiltersBarProps> = ({
Object.keys(updates).forEach(key => dispatch(clearDataMask(key)));
}
}
}, [JSON.stringify(filters), JSON.stringify(previousFilters)]);
}, [
JSON.stringify(filters),
JSON.stringify(previousFilters),
previousDashboardId,
]);
const dataMaskAppliedText = JSON.stringify(dataMaskApplied);