From 6441f692716e621c57ac076d80f653236c8e96d2 Mon Sep 17 00:00:00 2001 From: Vishal Jagtap <35190080+visshaljagtap@users.noreply.github.com> Date: Fri, 20 Jul 2018 05:15:56 +0530 Subject: [PATCH] Typo fixes in viz.py and CONTRIBUTING.md (#5432) --- CONTRIBUTING.md | 2 +- superset/viz.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 519644a4a..08547f040 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -493,7 +493,7 @@ https://github.com/apache/incubator-superset/pull/3013 In the future we'll start publishing release candidates for minor releases only, but typically not for micro release. The process will be similar to the process described above, expect the - tags will be formated `0.25.0rc1`, `0.25.0rc2`, ..., until consensus + tags will be formatted `0.25.0rc1`, `0.25.0rc2`, ..., until consensus is reached. We should also have a Github PR label process to target the proper diff --git a/superset/viz.py b/superset/viz.py index ef2e22fbc..d1732fa75 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -86,7 +86,7 @@ class BaseViz(object): self.force = force # Keeping track of whether some data came from cache - # this is useful to trigerr the when + # this is useful to trigger the when # in the cases where visualization have many queries # (FilterBox for instance) self._some_from_cache = False @@ -129,7 +129,7 @@ class BaseViz(object): return data def run_extra_queries(self): - """Lyfecycle method to use when more than one query is needed + """Lifecycle method to use when more than one query is needed In rare-ish cases, a visualization may need to execute multiple queries. That is the case for FilterBox or for time comparison @@ -156,7 +156,7 @@ class BaseViz(object): df = df.fillna(fillna) def get_fillna_for_col(self, col): - """Returns the value for use as filler for a specific Column.type""" + """Returns the value to use as filler for a specific Column.type""" if col: if col.is_string: return ' NULL' @@ -323,7 +323,7 @@ class BaseViz(object): We remove datetime bounds that are hard values, and replace them with the use-provided inputs to bounds, which - may we time-relative (as in "5 days ago" or "now"). + may be time-relative (as in "5 days ago" or "now"). """ cache_dict = copy.copy(query_obj)