From 67d8b634b885088b9977d04dc7dae1af8d180bfd Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Tue, 5 May 2020 21:43:33 -0700 Subject: [PATCH] fix: autocomplete search in AdhocFilter operator dropdown (#9654) Searching for 'equ' in AdhocFilter's operator dropdown doesn't find the options who's label contain that substring. I'd write a unit test but it's pretty tricky. --- .../components/AdhocFilterEditPopoverSimpleTabContent.jsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx b/superset-frontend/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx index eadaa5433..47bf94806 100644 --- a/superset-frontend/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx +++ b/superset-frontend/src/explore/components/AdhocFilterEditPopoverSimpleTabContent.jsx @@ -313,7 +313,11 @@ export default class AdhocFilterEditPopoverSimpleTabContent extends React.Compon .filter(operator => this.isOperatorRelevant(operator, adhocFilter.subject), ) - .map(operator => ({ operator })), + .map(operator => ({ + operator, + label: translateOperator(operator), + value: operator, + })), value: adhocFilter.operator, onChange: this.onOperatorChange, optionRenderer: VirtualizedRendererWrap(operator =>