iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Removes the TODOs and uses the default page size (#16422)

This commit is contained in:
Michael S. Molina 2021-08-24 11:44:27 -03:00 committed by GitHub
parent 575e7af859
commit 6a5568764e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
View File

@ -56,7 +56,6 @@ import {
Recipient,
} from './types';
const SELECT_PAGE_SIZE = 2000; // temporary fix for paginated query
const TIMEOUT_MIN = 1;
const TEXT_BASED_VISUALIZATION_TYPES = [
'pivot_table',
@ -1048,10 +1047,6 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
<Select
ariaLabel={t('Owners')}
allowClear
// TODO Use default page size (100). To do that, the server
// needs to send the total number of results. Currently, the
// number of results is limited to SELECT_PAGE_SIZE
pageSize={SELECT_PAGE_SIZE}
name="owners"
mode="multiple"
value={
@ -1099,10 +1094,6 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
<div className="input-container">
<Select
ariaLabel={t('Database')}
// TODO Use default page size (100). To do that, the server
// needs to send the total number of results. Currently, the
// number of results is limited to SELECT_PAGE_SIZE
pageSize={SELECT_PAGE_SIZE}
name="source"
value={
currentAlert?.database?.label &&
@ -1267,10 +1258,6 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
css={{
display: contentType === 'chart' ? 'inline' : 'none',
}}
// TODO Use default page size (100). To do that, the server
// needs to send the total number of results. Currently, the
// number of results is limited to SELECT_PAGE_SIZE
pageSize={SELECT_PAGE_SIZE}
name="chart"
value={
currentAlert?.chart?.label && currentAlert?.chart?.value
@ -1288,10 +1275,6 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
css={{
display: contentType === 'dashboard' ? 'inline' : 'none',
}}
// TODO Use default page size (100). To do that, the server
// needs to send the total number of results. Currently, the
// number of results is limited to SELECT_PAGE_SIZE
pageSize={SELECT_PAGE_SIZE}
name="dashboard"
value={
currentAlert?.dashboard?.label && currentAlert?.dashboard?.value