iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: remove --no-optional from docker-compose build (#29779)

This commit is contained in:
Maxime Beauchemin 2024-07-30 12:46:14 -07:00 committed by GitHub
parent 525e837c5b
commit 6bf8596d68
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docker-compose.yml
View File

@ -151,6 +151,7 @@ services:
environment: environment:
# set this to false if you have perf issues running the npm i; npm run dev in-docker # set this to false if you have perf issues running the npm i; npm run dev in-docker
# if you do so, you have to run this manually on the host, which should perform better! # if you do so, you have to run this manually on the host, which should perform better!
BUILD_SUPERSET_FRONTEND_IN_DOCKER: true
SCARF_ANALYTICS: "${SCARF_ANALYTICS:-}" SCARF_ANALYTICS: "${SCARF_ANALYTICS:-}"
container_name: superset_node container_name: superset_node
command: ["/app/docker/docker-frontend.sh"] command: ["/app/docker/docker-frontend.sh"]

10
docker/docker-frontend.sh
View File

@ -24,12 +24,16 @@ if [ "$PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" = "false" ]; then
fi fi
if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then
echo "Building Superset frontend in dev mode inside docker container"
cd /app/superset-frontend cd /app/superset-frontend
npm install -f --no-optional --global webpack webpack-cli
npm install -f echo "Running `npm install`"
npm install
echo "Running frontend" echo "Running frontend"
npm run dev npm run dev
else else
echo "Skipping frontend build steps - YOU RUN IT MANUALLY ON THE HOST!" echo "Skipping frontend build steps - YOU NEED TO RUN IT MANUALLY ON THE HOST!"
echo "https://superset.apache.org/docs/contributing/development/#webpack-dev-server"
fi fi