iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(legacy-preset-chart-nvd3): add richtooltip in nvd3 bar chart (#17615) 

* feat(legacy-preset-chart-nvd3): add richtooltip in nvd3 bar chart

* add richtooltip in nvd3 bar chart
This commit is contained in:
Stephen Liu 2021-12-02 15:23:31 +08:00 committed by GitHub
parent ce92fc152b
commit 72f3215ffc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts
View File

@ -35,6 +35,7 @@ import {
yAxisLabel,
yAxisShowMinmax,
yAxisBounds,
richTooltip,
} from '../NVD3Controls';
const config: ControlPanelConfig = {
@ -81,6 +82,7 @@ const config: ControlPanelConfig = {
['color_scheme'],
[showLegend],
[showBarValue],
[richTooltip],
[barStacked],
[
{

8
superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js
View File

@ -673,9 +673,9 @@ function nvd3Vis(element, props) {
chart.color(d => d.color || colorFn(cleanColorInput(d[colorKey])));
}
if (isVizTypes(['line', 'area']) && useRichTooltip) {
if (isVizTypes(['line', 'area', 'bar', 'dist_bar']) && useRichTooltip) {
chart.useInteractiveGuideline(true);
if (vizType === 'line') {
if (vizType === 'line' || vizType === 'bar') {
chart.interactiveLayer.tooltip.contentGenerator(d =>
generateRichLineTooltipContent(
d,
@ -683,6 +683,10 @@ function nvd3Vis(element, props) {
yAxisFormatter,
),
);
} else if (vizType === 'dist_bar') {
chart.interactiveLayer.tooltip.contentGenerator(d =>
generateCompareTooltipContent(d, yAxisFormatter),
);
} else {
// area chart
chart.interactiveLayer.tooltip.contentGenerator(d =>