diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js index f0430e1bf..11a03bdeb 100644 --- a/superset-frontend/.eslintrc.js +++ b/superset-frontend/.eslintrc.js @@ -83,7 +83,6 @@ module.exports = { 'jsx-a11y/anchor-has-content': 0, 'jsx-a11y/anchor-is-valid': 0, // disabled temporarily 'jsx-a11y/click-events-have-key-events': 0, // re-enable up for discussion - 'jsx-a11y/control-has-associated-label': 0, // disabled temporarily 'jsx-a11y/mouse-events-have-key-events': 0, // re-enable up for discussion 'lines-between-class-members': 0, // disabled temporarily 'new-cap': 0, @@ -198,7 +197,6 @@ module.exports = { 'jsx-a11y/anchor-has-content': 0, 'jsx-a11y/anchor-is-valid': 0, // disabled temporarily 'jsx-a11y/click-events-have-key-events': 0, // re-enable up for discussion - 'jsx-a11y/control-has-associated-label': 0, // disabled temporarily 'jsx-a11y/mouse-events-have-key-events': 0, // re-enable up for discussion 'lines-between-class-members': 0, // disabled temporarily 'new-cap': 0, diff --git a/superset-frontend/src/CRUD/CollectionTable.tsx b/superset-frontend/src/CRUD/CollectionTable.tsx index 2b1fc3950..61a5477d8 100644 --- a/superset-frontend/src/CRUD/CollectionTable.tsx +++ b/superset-frontend/src/CRUD/CollectionTable.tsx @@ -159,12 +159,14 @@ export default class CRUDCollection extends React.PureComponent< return ( - {expandFieldset && } + {expandFieldset && } {cols.map(col => ( {this.getLabel(col)} ))} {extraButtons} - {allowDeletes && !allowAddItem && } + {allowDeletes && !allowAddItem && ( + + )} {allowAddItem && (