From 7854b622a34c9a9674e2c916acb8acbc63714fb8 Mon Sep 17 00:00:00 2001 From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com> Date: Thu, 29 Feb 2024 08:53:09 -0500 Subject: [PATCH] fix: Data zoom with horizontal orientation (#27291) --- .../plugin-chart-echarts/src/Timeseries/transformProps.ts | 2 +- .../plugin-chart-echarts/src/Timeseries/transformers.ts | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts index 3ede7810d..8b4998ded 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts @@ -575,7 +575,6 @@ export default function transformProps( right: TIMESERIES_CONSTANTS.toolboxRight, feature: { dataZoom: { - yAxisIndex: false, title: { zoom: t('zoom area'), back: t('restore zoom'), @@ -590,6 +589,7 @@ export default function transformProps( start: TIMESERIES_CONSTANTS.dataZoomStart, end: TIMESERIES_CONSTANTS.dataZoomEnd, bottom: TIMESERIES_CONSTANTS.zoomBottom, + yAxisIndex: isHorizontal ? 0 : undefined, }, ] : [], diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts index 5b9fa4304..be89fdfc7 100644 --- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts +++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts @@ -570,9 +570,10 @@ export function getPadding( yAxisTitlePosition && yAxisTitlePosition === 'Top' ? TIMESERIES_CONSTANTS.gridOffsetTop + (Number(yAxisTitleMargin) || 0) : TIMESERIES_CONSTANTS.gridOffsetTop + yAxisOffset, - bottom: zoomable - ? TIMESERIES_CONSTANTS.gridOffsetBottomZoomable + xAxisOffset - : TIMESERIES_CONSTANTS.gridOffsetBottom + xAxisOffset, + bottom: + zoomable && !isHorizontal + ? TIMESERIES_CONSTANTS.gridOffsetBottomZoomable + xAxisOffset + : TIMESERIES_CONSTANTS.gridOffsetBottom + xAxisOffset, left: yAxisTitlePosition === 'Left' ? TIMESERIES_CONSTANTS.gridOffsetLeft +