iop
/
superset
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add more fields to the log API (#10271) 

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
This commit is contained in:
Bogdan 2020-07-13 18:06:33 -07:00 committed by GitHub
parent b316f723a1
commit 7abe3e5182
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
superset/views/log/api.py
View File

@ -28,5 +28,15 @@ class LogRestApi(LogMixin, BaseSupersetModelRestApi):
class_permission_name = "LogModelView"
resource_name = "log"
allow_browser_login = True
list_columns = ["user.username", "action", "dttm"]
list_columns = [
"user.username",
"action",
"dttm",
"json",
"slice_id",
"dashboard_id",
"user_id",
"duration_ms",
"referrer",
]
show_columns = list_columns

19
tests/log_api_tests.py
View File

@ -29,6 +29,19 @@ from superset.models.core import Log
from .base_tests import SupersetTestCase
EXPECTED_COLUMNS = [
"action",
"dashboard_id",
"dttm",
"duration_ms",
"json",
"referrer",
"slice_id",
"user",
"user_id",
]
class TestLogApi(SupersetTestCase):
def insert_log(
self,
@ -63,8 +76,7 @@ class TestLogApi(SupersetTestCase):
rv = self.client.get(uri)
self.assertEqual(rv.status_code, 200)
response = json.loads(rv.data.decode("utf-8"))
expected_columns = ["action", "dttm", "user"]
self.assertEqual(list(response["result"][0].keys()), expected_columns)
self.assertEqual(list(response["result"][0].keys()), EXPECTED_COLUMNS)
self.assertEqual(response["result"][0]["action"], "some_action")
self.assertEqual(response["result"][0]["user"], {"username": "admin"})
db.session.delete(log)
@ -96,8 +108,7 @@ class TestLogApi(SupersetTestCase):
self.assertEqual(rv.status_code, 200)
response = json.loads(rv.data.decode("utf-8"))
expected_columns = ["action", "dttm", "user"]
self.assertEqual(list(response["result"].keys()), expected_columns)
self.assertEqual(list(response["result"].keys()), EXPECTED_COLUMNS)
self.assertEqual(response["result"]["action"], "some_action")
self.assertEqual(response["result"]["user"], {"username": "admin"})
db.session.delete(log)