From 7cc0de1694edc6b6f2cd72806a930116a9d73686 Mon Sep 17 00:00:00 2001 From: Kamil Gabryjelski Date: Sat, 2 Jan 2021 01:08:19 +0100 Subject: [PATCH] Refetch samples only when filters change (#11999) --- .../src/explore/components/DataTablesPane.tsx | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/explore/components/DataTablesPane.tsx b/superset-frontend/src/explore/components/DataTablesPane.tsx index d9b3493c6..a9403c37f 100644 --- a/superset-frontend/src/explore/components/DataTablesPane.tsx +++ b/superset-frontend/src/explore/components/DataTablesPane.tsx @@ -138,12 +138,19 @@ export const DataTablesPane = ({ ); useEffect(() => { - setIsRequestPending({ + setIsRequestPending(prevState => ({ + ...prevState, [RESULT_TYPES.results]: true, - [RESULT_TYPES.samples]: true, - }); + })); }, [queryFormData]); + useEffect(() => { + setIsRequestPending(prevState => ({ + ...prevState, + [RESULT_TYPES.samples]: true, + })); + }, [queryFormData.adhoc_filters]); + useEffect(() => { if (panelOpen && isRequestPending[RESULT_TYPES.results]) { setIsRequestPending(prevState => ({