From 7d10669ca8c35d299c444fad384a6ec807b3ffa8 Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Mon, 20 Jul 2020 13:40:00 -0700 Subject: [PATCH] move control panel to filterbox folder (#10346) --- superset-frontend/src/setup/setupPlugins.ts | 2 -- .../src/visualizations/FilterBox/FilterBoxChartPlugin.js | 2 ++ .../FilterBox.jsx => visualizations/FilterBox/controlPanel.jsx} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename superset-frontend/src/{explore/controlPanels/FilterBox.jsx => visualizations/FilterBox/controlPanel.jsx} (100%) diff --git a/superset-frontend/src/setup/setupPlugins.ts b/superset-frontend/src/setup/setupPlugins.ts index b9c927db3..d386da596 100644 --- a/superset-frontend/src/setup/setupPlugins.ts +++ b/superset-frontend/src/setup/setupPlugins.ts @@ -29,7 +29,6 @@ import DeckPath from '../explore/controlPanels/DeckPath'; import DeckPolygon from '../explore/controlPanels/DeckPolygon'; import DeckScatter from '../explore/controlPanels/DeckScatter'; import DeckScreengrid from '../explore/controlPanels/DeckScreengrid'; -import FilterBox from '../explore/controlPanels/FilterBox'; import Separator from '../explore/controlPanels/Separator'; import TimeTable from '../explore/controlPanels/TimeTable'; @@ -38,7 +37,6 @@ export default function setupPlugins() { // TODO: Remove these shims once the control panel configs are moved into the plugin package. getChartControlPanelRegistry() - .registerValue('filter_box', FilterBox) .registerValue('separator', Separator) .registerValue('time_table', TimeTable) .registerValue('deck_arc', DeckArc) diff --git a/superset-frontend/src/visualizations/FilterBox/FilterBoxChartPlugin.js b/superset-frontend/src/visualizations/FilterBox/FilterBoxChartPlugin.js index 07513606d..711ac690d 100644 --- a/superset-frontend/src/visualizations/FilterBox/FilterBoxChartPlugin.js +++ b/superset-frontend/src/visualizations/FilterBox/FilterBoxChartPlugin.js @@ -20,6 +20,7 @@ import { t } from '@superset-ui/translation'; import { ChartMetadata, ChartPlugin } from '@superset-ui/chart'; import transformProps from './transformProps'; import thumbnail from './images/thumbnail.png'; +import controlPanel from './controlPanel'; const metadata = new ChartMetadata({ name: t('Filter Box'), @@ -32,6 +33,7 @@ const metadata = new ChartMetadata({ export default class FilterBoxChartPlugin extends ChartPlugin { constructor() { super({ + controlPanel, metadata, transformProps, loadChart: () => import('./FilterBox.jsx'), diff --git a/superset-frontend/src/explore/controlPanels/FilterBox.jsx b/superset-frontend/src/visualizations/FilterBox/controlPanel.jsx similarity index 100% rename from superset-frontend/src/explore/controlPanels/FilterBox.jsx rename to superset-frontend/src/visualizations/FilterBox/controlPanel.jsx