From 7d8383cbd5f75e59d996d5c67c2576e7a333bb45 Mon Sep 17 00:00:00 2001 From: Elizabeth Thompson Date: Thu, 2 Mar 2023 11:44:26 -0800 Subject: [PATCH] fix: ignore ts warnings from older typescript versions (#23262) --- superset-embedded-sdk/package-lock.json | 4 ++-- superset-embedded-sdk/package.json | 2 +- superset-embedded-sdk/src/index.ts | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/superset-embedded-sdk/package-lock.json b/superset-embedded-sdk/package-lock.json index 826fb282c..a8912e95d 100644 --- a/superset-embedded-sdk/package-lock.json +++ b/superset-embedded-sdk/package-lock.json @@ -1,12 +1,12 @@ { "name": "@superset-ui/embedded-sdk", - "version": "0.1.0-alpha.8", + "version": "0.1.0-alpha.9", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@superset-ui/embedded-sdk", - "version": "0.1.0-alpha.8", + "version": "0.1.0-alpha.9", "license": "Apache-2.0", "dependencies": { "@superset-ui/switchboard": "^0.18.26-0", diff --git a/superset-embedded-sdk/package.json b/superset-embedded-sdk/package.json index 055f44191..4ee8510a0 100644 --- a/superset-embedded-sdk/package.json +++ b/superset-embedded-sdk/package.json @@ -1,6 +1,6 @@ { "name": "@superset-ui/embedded-sdk", - "version": "0.1.0-alpha.8", + "version": "0.1.0-alpha.9", "description": "SDK for embedding resources from Superset into your own application", "access": "public", "keywords": [ diff --git a/superset-embedded-sdk/src/index.ts b/superset-embedded-sdk/src/index.ts index 56a07e554..d2513422f 100644 --- a/superset-embedded-sdk/src/index.ts +++ b/superset-embedded-sdk/src/index.ts @@ -150,6 +150,7 @@ export async function embedDashboard({ }); iframe.src = `${supersetDomain}/embedded/${id}${dashboardConfig}${filterConfigUrlParams}`; + //@ts-ignore mountPoint.replaceChildren(iframe); log('placed the iframe') }); @@ -173,6 +174,7 @@ export async function embedDashboard({ function unmount() { log('unmounting'); + //@ts-ignore mountPoint.replaceChildren(); }