diff --git a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx index 0a49d67e0..8e0bad30c 100644 --- a/superset-frontend/src/datasource/ChangeDatasourceModal.tsx +++ b/superset-frontend/src/datasource/ChangeDatasourceModal.tsx @@ -36,7 +36,12 @@ import Loading from '../components/Loading'; import withToasts from '../messageToasts/enhancers/withToasts'; const CONFIRM_WARNING_MESSAGE = t( - 'Warning! Changing the dataset may break the chart if the metadata (columns/metrics) does not exist in the target dataset', + 'Warning! Changing the dataset may break the chart if the metadata does not exist.', +); + +const CHANGE_WARNING_MSG = t( + 'Changing the dataset may break the chart if the chart relies ' + + 'on columns or metadata that does not exist in the target dataset', ); interface Datasource { @@ -83,11 +88,6 @@ const TABLE_COLUMNS = [ 'creator', ].map(col => ({ accessor: col, Header: col })); -const CHANGE_WARNING_MSG = t( - 'Changing the dataset may break the chart if the chart relies ' + - 'on columns or metadata that does not exist in the target dataset', -); - const emptyRequest = { pageIndex: 0, pageSize: 20, @@ -186,7 +186,7 @@ const ChangeDatasourceModal: FunctionComponent = ({ ); }); onHide(); - addSuccessToast('Successfully changed datasource!'); + addSuccessToast('Successfully changed dataset!'); }; const handlerCancelConfirm = () => { @@ -219,8 +219,25 @@ const ChangeDatasourceModal: FunctionComponent = ({ show={show} onHide={onHide} responsive - title={t('Select a dataset')} - hideFooter + title={t('Change Dataset')} + footer={ + <> + {confirmChange && ( + +
+ + +
+
+ )} + + } > <> {!confirmChange && ( @@ -251,23 +268,7 @@ const ChangeDatasourceModal: FunctionComponent = ({ )} )} - {confirmChange && ( - -
- {CONFIRM_WARNING_MESSAGE} -
- - -
-
-
- )} + {confirmChange && <>{CONFIRM_WARNING_MESSAGE}} );