From 84266bfa9ed1acd532eea611ec322a1eaa9480fa Mon Sep 17 00:00:00 2001 From: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Date: Tue, 19 Jan 2021 15:26:28 +0200 Subject: [PATCH] docs(release): add vote thread to result template (#12591) --- RELEASING/email_templates/result_pmc.j2 | 2 ++ RELEASING/send_email.py | 15 ++++++++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/RELEASING/email_templates/result_pmc.j2 b/RELEASING/email_templates/result_pmc.j2 index 9ea0c175f..be8804752 100644 --- a/RELEASING/email_templates/result_pmc.j2 +++ b/RELEASING/email_templates/result_pmc.j2 @@ -52,6 +52,8 @@ Negative votes: {% endfor -%} {%- endif %} +Link to vote thread: {{ vote_thread }} + We will work to complete the release process. Thanks, diff --git a/RELEASING/send_email.py b/RELEASING/send_email.py index cf1c94a4a..409672e34 100755 --- a/RELEASING/send_email.py +++ b/RELEASING/send_email.py @@ -193,9 +193,21 @@ def vote_pmc(base_parameters, receiver_email): type=str, prompt="A List of people with -1 vote (ex: John)", ) +@click.option( + "--vote_thread", + default="", + type=str, + prompt="Permalink to the vote thread " + "(see https://lists.apache.org/list.html?dev@superset.apache.org)", +) @click.pass_obj def result_pmc( - base_parameters, receiver_email, vote_bindings, vote_nonbindings, vote_negatives + base_parameters, + receiver_email, + vote_bindings, + vote_nonbindings, + vote_negatives, + vote_thread, ): template_file = "email_templates/result_pmc.j2" base_parameters.template_arguments["receiver_email"] = receiver_email @@ -208,6 +220,7 @@ def result_pmc( base_parameters.template_arguments["vote_negatives"] = string_comma_to_list( vote_negatives ) + base_parameters.template_arguments["vote_thread"] = vote_thread message = render_template(template_file, **base_parameters.template_arguments) inter_send_email( base_parameters.username,