From 8484ee653f7e8d1784dfbb208ac8f49cb2cbad2f Mon Sep 17 00:00:00 2001 From: Yongjie Zhao Date: Mon, 24 May 2021 13:53:14 +0100 Subject: [PATCH] fix: extra query in Dashboard when native filter enabled (#14770) --- .../dashboard/components/nativeFilters/FilterBar/index.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx index 534866b57..3d6f7eb16 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx @@ -187,8 +187,11 @@ const FilterBar: React.FC = ({ setIsFilterSetChanged(tab !== TabIds.AllFilters); setDataMaskSelected(draft => { const children = cascadeChildren[filter.id] || []; - // force instant updating on initialization or for parent filters - if (filter.isInstant || children.length > 0) { + // force instant updating on initialization or for parent filters when dataMaskSelected has filter + if ( + dataMaskSelected[filter.id] && + (filter.isInstant || children.length > 0) + ) { dispatch(updateDataMask(filter.id, dataMask)); }