From 86651cd451a29335b5e9aee6600c831074a510ed Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Mon, 16 Nov 2020 09:26:07 -0800 Subject: [PATCH] fix: default dashboard/chart cards are vector with perfect corners (#11684) * fix: default dashboard/chart cards are vector with perfect corners * fix: adding licenses --- .../images/chart-card-fallback.png | Bin 3183 -> 0 bytes .../images/chart-card-fallback.svg | 27 ++++++++++++++++++ .../images/dashboard-card-fallback.png | Bin 2621 -> 0 bytes .../images/dashboard-card-fallback.svg | 22 ++++++++++++++ .../ListViewCard/ListViewCard.stories.tsx | 4 +-- .../src/views/CRUD/chart/ChartCard.tsx | 2 +- .../views/CRUD/dashboard/DashboardCard.tsx | 2 +- 7 files changed, 53 insertions(+), 4 deletions(-) delete mode 100644 superset-frontend/images/chart-card-fallback.png create mode 100644 superset-frontend/images/chart-card-fallback.svg delete mode 100644 superset-frontend/images/dashboard-card-fallback.png create mode 100644 superset-frontend/images/dashboard-card-fallback.svg diff --git a/superset-frontend/images/chart-card-fallback.png b/superset-frontend/images/chart-card-fallback.png deleted file mode 100644 index aa34d4f0136d52dd767e21bd179f961d5f58b024..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 3183 zcmdT_dr;F?7XAe(BG^)}D{rE$)?g7tsRj}Ph=2;lA|fb(sEBTXAQ6%Pl0@qQRUpwy zi4RP$2&j-ld;bCGI(r1OTRMJ^%vTEU?lW zAxQ@Vb^)9&yEpoU;c1`!J^)ZjH(fgZ5df?<+`HT7Pzq#HuAs>dQ(9&e>pizKmnu*H zz_~D3%V>&tw^!ptzS``gH74gpalKuLE^A-5xb}i6w`YWF>yZIJ`Ez%keS6Jl`wu9n zcYY?<(f^Z$9{0PCEv_x=}&K<}SCh8wEN@^zBE z)XjG@sLKrMdy#@+BTf-4u-?=?9Q*s>N2^*KwY*EVUIIJK6c+kp+po~)W?^dR!h(y5 zBT)LS`*=CZE>}3~7N=!JUK&=6d3gkcAR&d>Hj;xv0?b9O28rYO zTP9ARPv}x54z)31kpLjLdEUVLyZ=KxDgw~`N5V$NH6YvzECTs3Nu4s zp2ipy!D+$#O1YwuZ0Uk+x^&#CUz~W)@H2F{f{`*eA$whlrup9QDHtoBv*vO#ctKY= zpi6OfM+eH;*?FWv<#M9Z7#?1dIQ)-DFJ0{AqeqOAY_{~uw%v`4XfE?$vd7ldY4NVP z$${xfvm1u4tb!F(bcj^olTh_Loaq|}|2t~8#E9w5-JM&7ZGA^t)^E=+-Bg~*_T$)q z$so_>>fq1kKzeWAEM#S;u|6q8eQBPI*K_r>=cyx%&Z0I?Pw}RXOnK?|!zg`do=p{= zrrdlN41Po7+6S;tD<7?2^9?+P@VIXz6=8rQ5o~r6rCp7a`I}(u=%cLYqdOLiO;>ig z>U~DX9Czap2JFskT~MWSX>1^(nNOj4a-dV$<}hG`@m~~3lOgnN!bT29KvP$v_?&DD zas*0vLK9OrUlDCxLi(AUGip_AE7Nt#NHcGHZdqmC(WSp`q#zF&n2_#G2O`hS;od!` zQ0(@}!2@cPcEFXiWkby6ph&7?BqnMOkH?!UJgMf{es*pTp=LK6F+5-C0l`gTdrW;R z%O5ezUF{>ypMF3SJ#dFjQZPYZ)LJMoo|k-8v!nXb^L!a}u@vzpmPv_U|FRVp%M`|g zksp;<3wdxv_HRyl!b$h0uFKGTJ>$bXn_&6R=cFGP$N#F&@}z%ZVpjiC$Krvh0`SRw zhorKOF-aGbsk#=^Iu%kd-wBF*zbs4?jnh&JNONVMmIs6)`iXWG%+R#e|GMOT+V%df zWujrv)VSNp3C?Zz{w)V8j))3TqMCSkCjD57E~Uk8MMi^L0@Gkk-52-xVwx_<+_}^y z5P{--cmc~%sd|?jZ^$~IzbJ--TP`5LeV9n9z3MbMInr{YhMS(#_O2sg+FZ0PXnLF0 zO60n4Cs%u`ZhAynw$pXBuhtsA-=N(G)LMv{WLw>fr+8TH&F78nsMg-vPZ^HS2)g2A zd}^Plt<5iee#y^iEu;Vz!n3OZOR@Wdzv?)KE^14Q$gGL$Accymd+c5jy_`#~CR{qh zVHzg#4f8G%7Z=j)>tmVCxb^Z@STfTnLC-t?H{MN$l5adx7WP!sJ_(J!onRmK#WO_8 znFWbQ1M2*mQ-T@#g(Gj6KLacb|3_fV^28qhMnKd1Q;K|gWjL0)y)0^V z!>!((wCILJLX#j>>m1dbwx)G!4GZG%IV7g6*=1&;uTDZLGYyn73EI^W(p{L6JW6)Y8&&My|H33^#1Kc+!Ny=CCMV`>~xay63J1an{c`TNI)8;=@T-WIEn;fBwei z`ZNo`?8oy}J<3rv;njmw4L2j%tf)KHhQ}uT?e!_E(UA!!z+rO;FFv%j_w%q^0-u1% z-7`JZBn<#3G(bv4j(6XK+XEr(xPkE})ehC=`rkJ4`)_*;ko>$C%l|`T4fI;lPW*F? z{q?-NQ9JPuHFn6^>cXEiSn-7_xzN(?h0BhGSJ!SdP&Q2orI4;LvZJkZWi6S76-+jW zCP(kCf<@Hce!7+8;6lQxGafP!1ut(Yi+{<-h6@_w`&A?wS3D}d6augdICk>{5K zOSMBpo*+A|ol4TeaR%*&sgy;Jwb^{cn_f`{iZ}6+){9{0g1Nn_2U-y{ zN~f%*D(3o{wF4-0#G+t%`C_UGc3Ys1y>xHXGJtkR+H!J$ptmR-jE@w?f&6EuJ$7d^+vjG9Z^calV@WJSS%MWw@5E! z6MqZ}G+2Wu0)`Utg6=i=*zDn%5qSk%L!OY(z2lHn^~7dp2Ue|U7RnPQ>DpcZugd4{ zBq8Irx(MKO>O$x9ltVP?ck0*6rmQHkxo#YKHm6O)#T+xTT^Hw&^UL;gN#B5|`EgAL zoEU(;;^Kg%q~Hfw^%?^}aIn5 + + + + + + + + + diff --git a/superset-frontend/images/dashboard-card-fallback.png b/superset-frontend/images/dashboard-card-fallback.png deleted file mode 100644 index 1b4e968a09f98dde433691f1e75f8ba5876ffd4f..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2621 zcmcgu`CC(08or5u6e{SjL}gWLk!gcg5JXwxf=h!yRfrfOQUw$U(FaUeF1rpRR4A6R zG$2%mVGv11lmrPR0tGtN5M>X^B~>002qXcoAqgR2ZlC!F=7(W^_?~mlch0xH&wI}K z?uLb&++?xc0sw$br%xR}3jnA$h?tw3AsW@bhNH;v$&FKyDF9$;^M{~-pK7)uN>s|( zlScu@pyM2}Fo{2M<_G{hEwx;YF+~i9P9HyVJ`JUSx~by0Z38ja7q(t(+)ZjN*v)Zf z+)jLVqJ2ZViN~GYHN9y2n%)xh>6-gjKRe-BwyV@lt!0i3x%mrxn+9wI53}@hZdtoT zx7uJC&j4f8dWDO;!^nF46NXGAa0a00aIz=@_@_5%Bgf1+W8!?Fcd~IJYJ_JP-J4_7 zbQH&{v-OQoG;j8ia7zdZ12rm7DV2j@sz}RMoSZxP+7A{zgE0?9^zzP zNW@w52S6DgtRydhc(xWRHfH_Mp)?bU(@W+c-j2Ts1#)p;JQt4RzVfDW8;GlRvq9km zI&{4UW-^+Ki;KIf@0%WUgD%d;!^;YhT&mWD508y5=lNDsw!NkahjbOmON4qTjAsd5bqchR&c1VJ0_iaa4MkhM+SoC3f^}{3w^pryQWEK=)(pSj}b_TdDI9 z`NCKzfoENwzI{+CHoeB3*(Zs`BVdM$@8GKkyYN5kN5ZwlP@CKD&e~e07zeA%bQQ0_ z$}>33`w>_22L5nUoi|)H?zi0LhlNS3tK8khAY7=S{L_kFu#yi}H;)@~`tSGj;~xJ>HpvF{Zxge(YC4xt*-I0uMbpe{~R z>Z2EMz9{Dqz6fq`T3}nrhH|p4;992OE6M#&_5?L+2(ENPj{>v!ZYgF*CNC+0pKOoO zpCs@56t3mmgt4_6oO=}Q1~lay7WhD&T*A^<9i`oHqFp{9@pTB4v?4wZN8O7OI|q+< zR>`iV%}mTW2gW4|K-nKxE#9*7;Vr`Fy&SJX5g5#@8(6GgsS;MHI`7p|=1j^TI#H%K z32r-GZ5$W;KJw*YwV+Y@%Fi)6&)F+{jjJ9K_L#a-1Iy{7Ni!CE`sOk6#pxy1pBAUJ zBP%JU7M_}>mW#yp#piz!sS{tI)y_ycbXLbity#dD{FVH}hxfmfrrUg@y$Kn<$%X_k zvkY>+(J)VLOJd;MC;Ng(U0UgUmY>QdG%bNZ5G*IQUg|E5v<)j-o>7NV*u^W@M=XUB zZ5yh6>NGW<6yRsnMzL)BsF-sF;6+B%9`myKA&F@9naktC}T*5ND-ErWOknh%DEIVJ|2CZ5SUK= z$fnyR?SCy|bvW?iL=hqd71K|Lc7j?p5^ftO8&6o9VXj^HcztEj0W2&~@+jA*cgCLO z7nXg5w`Thl>UvW98Iqp1Vjh|-QY6=7^m$f=lP*c@A9pR3%jMJGa(Lz(pMyDCk{Ntw z?mH5%f!NJ{>S(m%Fc|aa>2ZqCKF2geQ$MK~r@0t_zw0Jy z#2NnTuG+?`y}{STD_H3LhKzA(FHS{Ke|0aE+!gm4^I%9u;>|<`;R=1K9qX_{DSc{5 zC~uD|X>GZVE$v}3TW$r@TTyFJi3hM;|Aj4~H-%QR!PD&04rz@HX@l#Cyz u{7Xzmty917-*fuqj53sn0!rT+U9#=kzK;p^^+38k;B-*PamLZh`Tqvitx@&> diff --git a/superset-frontend/images/dashboard-card-fallback.svg b/superset-frontend/images/dashboard-card-fallback.svg new file mode 100644 index 000000000..eaf2d5c68 --- /dev/null +++ b/superset-frontend/images/dashboard-card-fallback.svg @@ -0,0 +1,22 @@ + + + + + diff --git a/superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx b/superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx index 2af54957b..6daf43d5f 100644 --- a/superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx +++ b/superset-frontend/src/components/ListViewCard/ListViewCard.stories.tsx @@ -19,8 +19,8 @@ import React from 'react'; import { action } from '@storybook/addon-actions'; import { withKnobs, boolean, select, text } from '@storybook/addon-knobs'; -import DashboardImg from 'images/dashboard-card-fallback.png'; -import ChartImg from 'images/chart-card-fallback.png'; +import DashboardImg from 'images/dashboard-card-fallback.svg'; +import ChartImg from 'images/chart-card-fallback.svg'; import { Dropdown, Menu } from 'src/common/components'; import Icon from 'src/components/Icon'; import FaveStar from 'src/components/FaveStar'; diff --git a/superset-frontend/src/views/CRUD/chart/ChartCard.tsx b/superset-frontend/src/views/CRUD/chart/ChartCard.tsx index 34a91c140..8df4f02b8 100644 --- a/superset-frontend/src/views/CRUD/chart/ChartCard.tsx +++ b/superset-frontend/src/views/CRUD/chart/ChartCard.tsx @@ -133,7 +133,7 @@ export default function ChartCard({ title={chart.slice_name} url={bulkSelectEnabled ? undefined : chart.url} imgURL={chart.thumbnail_url || ''} - imgFallbackURL="/static/assets/images/chart-card-fallback.png" + imgFallbackURL="/static/assets/images/chart-card-fallback.svg" description={t('Last modified %s', chart.changed_on_delta_humanized)} coverLeft={} coverRight={ diff --git a/superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx b/superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx index e45d7fa6b..2550dc6eb 100644 --- a/superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx +++ b/superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx @@ -139,7 +139,7 @@ function DashboardCard({ } url={bulkSelectEnabled ? undefined : dashboard.url} imgURL={dashboard.thumbnail_url} - imgFallbackURL="/static/assets/images/dashboard-card-fallback.png" + imgFallbackURL="/static/assets/images/dashboard-card-fallback.svg" description={t( 'Last modified %s', dashboard.changed_on_delta_humanized,